On Mon, Jul 30, 2018 at 06:39:04AM +0200, Sebastian Bauer wrote: > The four interrupts of the PCI bus are connected to the same UIC pin on the > real Sam460ex. Evidence for this can be found in the UBoot source for the > Sam460ex in the Sam460ex.c file where PCI_INTERRUPT_LINE in written. This > change brings the connection in line with this. > > This fixes the problem that can be observed when adding further PCI cards > that get their interrupt rotated to other interrupts than PCI INT A. In > particular, the bug was observed and verified to be fixed (after this > change) with an additional OHCI PCI card. > > Signed-off-by: Sebastian Bauer <[email protected]>
Applied to ppc-for-3.0.
> ---
> hw/ppc/sam460ex.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c
> index 0999efcc1e..b2b22f280d 100644
> --- a/hw/ppc/sam460ex.c
> +++ b/hw/ppc/sam460ex.c
> @@ -515,9 +515,9 @@ static void sam460ex_init(MachineState *machine)
>
> /* PCI bus */
> ppc460ex_pcie_init(env);
> - /* FIXME: is this correct? */
> + /* All PCI ints are connected to the same UIC pin (cf. UBoot source) */
> dev = sysbus_create_varargs("ppc440-pcix-host", 0xc0ec00000,
> - uic[1][0], uic[1][20], uic[1][21],
> uic[1][22],
> + uic[1][0], uic[1][0], uic[1][0], uic[1][0],
> NULL);
> pci_bus = (PCIBus *)qdev_get_child_bus(dev, "pci.0");
> if (!pci_bus) {
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
