On 07/24/2018 10:31 AM, Aleksandar Markovic wrote:
> + case NM_ADDIUPC:
> + if (rt != 0) {
> + int32_t offset = sextract32(ctx->opcode, 0, 1) << 21
> + | extract32(ctx->opcode, 1, 20) << 1;
> + target_long addr = addr_add(ctx, ctx->base.pc_next + 4, offset);
> + tcg_gen_movi_tl(cpu_gpr[rt], addr);
> + tcg_gen_ext32s_tl(cpu_gpr[rt], cpu_gpr[rt]);
> + }
I really need you to address all of the comments from a round of review before
posting the next round.
I'm going to stop now, let you address all of the v3 review and then post a v5.
r~
