On 07/18/2018 04:05 AM, Markus Armbruster wrote:
Making 'allow-oob' optional in SchemaInfoCommand permits omitting it
in the common case. Shrinks query-qmp-schema's output from 122.1KiB
to 118.6KiB for me.
Note that out-of-band execution is still experimental (you have to
configure the monitor with x-oob=on to use it).
Signed-off-by: Markus Armbruster <[email protected]>
---
I see you have already posted the pull request, but the idea makes sense
to me. In general, making what was previously always output now be
optional can risk confusing a client that depends on the value being
present; but since allow-oob has not always been present, and since it
is still gated by x-oob=on, any sane client using OOB can easily be
coded to treat an absent indication as not allowing oob for that
particular command.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
