On Wed, Jul 11, 2018 at 07:20:42PM +0200, Paolo Bonzini wrote: > On 09/07/2018 23:03, Thomas Huth wrote: > > > > The problem is that qdev_set_parent_bus() from instance_init adds a link > > to the child devices which is not valid anymore after the device init > > failed. Thus the qdev_set_parent_bus() must rather be done in the realize > > function instead. > > The theoretical behavior should be:
It's not clear below where you expect qdev_set_parent_bus(..., sysbus_get_default()) to be called (if it should be called at all). I don't know where it should be called, but I'm absolutely sure instance_init is not the right place. > > - realize fails > > - object_unparent is called on the device that failed to realize (see > qdev_device_add). object_unparent calls device_unparent > > - after device_unparent finishes, the last reference to the device has > been dropped and the device is freed > > - object finalization releases all properties > > - this includes child properties, so for each child device > object_unparent is called > > - again device_unparent is called (for the child) and this removes the > child from the bus. > > Paolo -- Eduardo
