On 07/02/2018 05:01 AM, Stafford Horne wrote: >> ERROR: spaces required around that '*' (ctx:WxV) >> #129: FILE: target/openrisc/disas.c:56: >> + arg_l_##opcode *a, uint32_t insn) \ >> ^ >> >> ERROR: spaces required around that '*' (ctx:WxV) >> #224: FILE: target/openrisc/disas.c:151: >> + arg_lf_##opcode##_##suffix *a, uint32_t insn) \ >> ^ > > I have fixed these on my branch.
These should not have been "fixed". This is checkpatch being stupid and not realizing that the thing on the left is a type and this is a pointer declaration, not a multiplication. r~
