On 27 June 2018 at 05:33, Richard Henderson <richard.hender...@linaro.org> wrote: > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > > --- > v6: Rearrange the loops. The compiler does well with this form > and hopefully they are also easier to read. > ---
Definitely easier to read, thanks. > diff --git a/target/arm/sve.decode b/target/arm/sve.decode > index 35415bfb6c..e10b689454 100644 > --- a/target/arm/sve.decode > +++ b/target/arm/sve.decode > @@ -726,7 +726,13 @@ UMIN_zzi 00100101 .. 101 011 110 ........ ..... > @rdn_i8u > MUL_zzi 00100101 .. 110 000 110 ........ ..... @rdn_i8s > > # SVE integer dot product (unpredicated) > -DOT_zzz 01000100 1 sz:1 0 rm:5 00000 u:1 rn:5 rd:5 > +DOT_zzz 01000100 1 sz:1 0 rm:5 00000 u:1 rn:5 rd:5 > ra=%reg_movprfx Shouldn't this have been in a different patch ? > + > +# SVE integer dot product (indexed) > +DOT_zzx 01000100 101 index:2 rm:3 00000 u:1 rn:5 rd:5 \ > + sz=0 ra=%reg_movprfx > +DOT_zzx 01000100 111 index:1 rm:4 00000 u:1 rn:5 rd:5 \ > + sz=1 ra=%reg_movprfx > > # SVE floating-point complex add (predicated) > FCADD 01100100 esz:2 00000 rot:1 100 pg:3 rm:5 rd:5 \ > -- > 2.17.1 > Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
