On 06/27/2018 01:51 AM, Gerd Hoffmann wrote:
Signed-off-by: Martin Schrodt <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
Message-id: [email protected]
Message-id: [email protected]
[ kraxel: keep old code for compatibility with older qemu versions,
add property to switch code paths at runtime ]
[ kraxel: new code is disabled by default, use-timer=on enables it ]
Signed-off-by: Gerd Hoffmann <[email protected]>
---
hw/audio/hda-codec.c | 263 ++++++++++++++++++++++++++++++++++++++++++++++-----
hw/audio/intel-hda.c | 7 --
2 files changed, 237 insertions(+), 33 deletions(-)
This patch breaks compilation on clang with -m32 for me, because I
apparently I don't have 64 bit atomics there. Should there be
CONFIG_ATOMIC64 guards and handling for when that isn't defined?
Given the code runs under big qemu lock anyway the atomics are not
needed, so we could drop just them. I left them in nevertheless because
(a) we might want try run the code in a thread instead of using a timer, and
(b) I was too lazy to rewrite the code to drop the atomics.
I'd prefer to keep option (a) ...
what about option (c): figure out how to use util/stats64.c which is a
way of getting 64-bit atomic math even on 32-bit hosts?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
