Hi Thomas,
On 26.06.2018 10:45, Thomas Huth wrote:
> On 26.06.2018 10:17, Steffen Görtz wrote:
> [...]
>> +static const MemoryRegionOps io_ops = { .read = io_read, .write = io_write,
>> + .endianness = DEVICE_LITTLE_ENDIAN, };
>
> Could you please put the entries on a separate line each? That would be
> better readable.
done
>
>> +static void nrf51_nvmc_init(Object *obj)
>> +{
>> + Nrf51NVMCState *s = NRF51_NVMC(obj);
>> + SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
>> +
>> + memory_region_init_io(&s->mmio, obj, &io_ops, s,
>> + TYPE_NRF51_NVMC, NRF51_NVMC_SIZE);
> Please indent the second line of the memory_region_init_io statement.
done
>
>> + sysbus_init_mmio(sbd, &s->mmio);
>> +#include "hw/sysbus.h"
>> +#include "qemu/timer.h"
>
> Any reason for including timer.h here? If not, please drop that line.
No it was a left over, removed.
Best regards,
Steffen
