On Tue, Jun 26, 2018 at 10:48:10AM +0200, Paolo Bonzini wrote: > On 26/06/2018 10:35, Markus Armbruster wrote: > > We also want to deprecate usb-storage, but > > I guess we're still not ready for that (it's a complicated story). > > > > To deprecate -drive without also deprecating usb-storage, we need to > > preserve features. > > Patch looks good to me too, but indeed why can't we deprecate > usb-storage in favor of usb-bot + scsi-disk?
I think we can. One blocking issue was hotplug support, but that got fixed a while ago, and I'm not aware of any other issue ... cheers, Gerd commit b78ecd0998094a8b7e0f14c4888f3a6b525d14ff Author: Gerd Hoffmann <[email protected]> Date: Wed Jun 15 11:46:58 2016 +0200 usb-bot: hotplug support This patch marks usb-bot as hot-pluggable device, makes attached property settable and turns off auto-attach in case the device was hotplugged. Hot-plugging a usb-bot device with one or more scsi devices can be done this way now: (1) device-add usb-bot,id=foo (2) device-add scsi-{hd,cd},bus=foo.0,lun=0 (2b) optionally add more devices (luns 0 ... 15). (3) qom-set foo.attached = true Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Message-id: [email protected]
