On 22.06.2018 15:40, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > hw/input/tsc2005.c | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c > index 7990954b6c..4dd95596ab 100644 > --- a/hw/input/tsc2005.c > +++ b/hw/input/tsc2005.c > @@ -19,6 +19,7 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu/log.h" > #include "hw/hw.h" > #include "qemu/timer.h" > #include "ui/console.h" > @@ -208,9 +209,10 @@ static void tsc2005_write(TSC2005State *s, int reg, > uint16_t data) > } > s->nextprecision = (data >> 13) & 1; > s->timing[0] = data & 0x1fff; > - if ((s->timing[0] >> 11) == 3) > - fprintf(stderr, "%s: illegal conversion clock setting\n", > - __func__); > + if ((s->timing[0] >> 11) == 3) { > + qemu_log_mask(LOG_GUEST_ERROR, > + "tsc2005_write: illegal conversion clock > setting\n"); > + } > break; > case 0xd: /* CFR1 */ > s->timing[1] = data & 0xf07; > @@ -221,8 +223,9 @@ static void tsc2005_write(TSC2005State *s, int reg, > uint16_t data) > break; > > default: > - fprintf(stderr, "%s: write into read-only register %x\n", > - __func__, reg); > + qemu_log_mask(LOG_GUEST_ERROR, > + "%s: write into read-only register 0x%x\n", > + __func__, reg); > } > } >
Reviewed-by: Thomas Huth <[email protected]>
