On 22.06.2018 15:40, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > hw/input/pckbd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c > index f33e3fc63d..26aeac2326 100644 > --- a/hw/input/pckbd.c > +++ b/hw/input/pckbd.c > @@ -22,6 +22,7 @@ > * THE SOFTWARE. > */ > #include "qemu/osdep.h" > +#include "qemu/log.h" > #include "hw/hw.h" > #include "hw/isa/isa.h" > #include "hw/i386/pc.h" > @@ -308,7 +309,8 @@ static void kbd_write_command(void *opaque, hwaddr addr, > /* ignore that */ > break; > default: > - fprintf(stderr, "qemu: unsupported keyboard cmd=0x%02x\n", (int)val); > + qemu_log_mask(LOG_GUEST_ERROR, > + "unsupported keyboard cmd=0x%02lx\n", val);
Sorry for not spotting it in v1 already, but val is a uint64_t value, so you need PRIx64 as format string here, otherwise you'll get an error with 32-bit compilers. Thomas
