On Fri, Jun 22, 2018 at 03:31:48AM +0300, Michael S. Tsirkin wrote:
[...]
> - enable_mlock = qemu_opt_get_bool(opts, "mlock", true);
> + /* Don't override the -dedicated option if set */
> + enable_mlock = enable_mlock ||
> + qemu_opt_get_bool(opts, "mlock", true);
> + break;
> + case QEMU_OPTION_dedicated:
> + opts = qemu_opts_parse_noisily(qemu_find_opts("dedicated"),
> + optarg, false);
> + if (!opts) {
> + exit(1);
> + }
> + /* Don't override the -realtime option if set */
> + enable_mlock = enable_mlock ||
> + qemu_opt_get_bool(opts, "mem-lock", false);
> + enable_cpu_pm = qemu_opt_get_bool(opts, "cpu-pm", false);
I would prefer to simply make the last option win, because it
would be more obvious. But not a big deal if we are going to
deprecate -realtime.
BTW, are you going to send a qemu-doc.texi patch documenting
-realtime as deprecated?
--
Eduardo
