On 06/20/2018 05:05 AM, Yongbok Kim wrote: > From: Yongbok Kim <yongbok....@imgtec.com> > > Add nanoMIPS OPCODE table > > Reference: > nanoMIPS Base ISA Technical Reference Manual > > Signed-off-by: Yongbok Kim <yongbok....@mips.com> > --- > target/mips/mips-defs.h | 4 + > target/mips/translate.c | 670 > ++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 674 insertions(+)
I realize it's newish, and the mips target has a *lot* of legacy code and decode, but have you looked at qemu/scripts/decodetree.py? I think it would make a lot of this code significantly simpler. How about simply splitting out this new code to a new file? After your patch, target/mips/translate.c weighs in at 23698 lines; you're adding over 3000 to that in this patch set. That said, this patch matches a few spot checks I did of the manual. Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~
