Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: [email protected] Subject: [Qemu-devel] [PATCH v1 0/6] QGA: systemd hibernate/suspend/hybrid-sleep === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' cc696f1009 qga: removing bios_supports_mode dc712bbec2 qga: adding systemd hibernate/suspend/hybrid-sleep support 3be456b7f1 qga: removing switch statements, adding run_process_child 31cf0e6b15 qga: guest_suspend: decoupling pm-utils and sys logic 314d3a05ca qga: bios_supports_mode: decoupling pm-utils and sys logic da135a7c9f qga: refactoring qmp_guest_suspend_* functions === OUTPUT BEGIN === Checking PATCH 1/6: qga: refactoring qmp_guest_suspend_* functions... Checking PATCH 2/6: qga: bios_supports_mode: decoupling pm-utils and sys logic... Checking PATCH 3/6: qga: guest_suspend: decoupling pm-utils and sys logic... Checking PATCH 4/6: qga: removing switch statements, adding run_process_child... ERROR: "(foo* const*)" should be "(foo * const*)" #91: FILE: qga/commands-posix.c:1467: + execve(cmd_path, (char* const*)command, environ); ERROR: space required before that '*' (ctx:VxB) #91: FILE: qga/commands-posix.c:1467: + execve(cmd_path, (char* const*)command, environ); ^ total: 2 errors, 0 warnings, 295 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/6: qga: adding systemd hibernate/suspend/hybrid-sleep support... Checking PATCH 6/6: qga: removing bios_supports_mode... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
