On Fri, Jun 08, 2018 at 07:38:11AM +0200, Markus Armbruster wrote: [...]
> > +/* > > + * This should never be called before configure_accelerator() since > > + * only until then could we know whether qtest was enabled or not. > > Uh, we know it after then, not until then. What about > > /* > * Return the clock to use for recording an event's time. > * Beware: result is invalid before configure_accelerator(). Oh, another Chinglish from me. :( > > > + */ > > +static inline QEMUClockType monitor_get_clock(void) > > Suggest to rename to monitor_get_event_clock(), or just > get_event_clock(). > > Happy to apply touch-ups on commit. That'll be appreciated. Both changes work for me. [...] > With at least a suitable fix for the comment: > Reviewed-by: Markus Armbruster <[email protected]> Thanks! -- Peter Xu
