"Dr. David Alan Gilbert (git)" <dgilb...@redhat.com> writes:
> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
>
> Add a flag to command definitions to allow them to be used in preconfig
> and check it.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> ---
> monitor.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/monitor.c b/monitor.c
> index 6d0cec552e..50b95f41db 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -128,6 +128,7 @@ typedef struct mon_cmd_t {
> const char *args_type;
> const char *params;
> const char *help;
> + const char *flags; /* p=preconfig */
> void (*cmd)(Monitor *mon, const QDict *qdict);
> /* @sub_table is a list of 2nd level of commands. If it does not exist,
> * cmd should be used. If it exists, sub_table[?].cmd should be
> @@ -936,6 +937,19 @@ static int parse_cmdline(const char *cmdline,
> return -1;
> }
>
> +/*
> + * Returns true if the command can be executed in preconfig mode
> + * i.e. it has the 'p' flag.
> + */
> +static bool cmd_can_preconfig(const mon_cmd_t *cmd)
> +{
> + if (!cmd->flags) {
> + return false;
> + }
> +
> + return strchr(cmd->flags, 'p');
> +}
> +
> static void help_cmd_dump_one(Monitor *mon,
> const mon_cmd_t *cmd,
> char **prefix_args,
> @@ -2976,6 +2990,11 @@ static const mon_cmd_t *monitor_parse_command(Monitor
> *mon,
> (int)(p - cmdp_start), cmdp_start);
> return NULL;
> }
> + if (runstate_check(RUN_STATE_PRECONFIG) && !cmd_can_preconfig(cmd)) {
> + monitor_printf(mon, "Command '%.*s' not available in preconfig\n",
> + (int)(p - cmdp_start), cmdp_start);
> + return NULL;
> + }
>
> /* filter out following useless space */
> while (qemu_isspace(*p)) {
This
(qemu) c
Command 'c' not available in preconfig
is not a nice user experience. We can do better (paraphrasing myself):
Command 'c' not available with -preconfig until you complete
configuration with QMP
Note that this talks to the user in the user's terms (-preconfig)
instead of internal terms ("in preconfig", whatever that is), and is
more specific on how to ready the monitor.
Obviously, "with QMP" needs an update once HMP acquires a command to
exit preconfig state.
