Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 152819515565.30857.16834004920507717324.stgit@pasha-ThinkPad-T60
Subject: [Qemu-devel] [RFC PATCH v2 0/7] QEMU binary instrumentation prototype
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20180605160958.5434-1-laur...@vivier.eu ->
patchew/20180605160958.5434-1-laur...@vivier.eu
* [new tag] patchew/20180605162545.80778-1-dgilb...@redhat.com
-> patchew/20180605162545.80778-1-dgilb...@redhat.com
Switched to a new branch 'test'
8e2137159d plugins: add syscall logging plugin sample
4f83688387 plugin: add instruction execution logger
01b6290540 plugins: add plugin template
8db7f62ef5 tcg: add instrumenting module
2d2144d202 plugins: provide helper functions for plugins
6630aa42d3 Add plugin support
f31baee853 tcg: add headers for non-target helpers
=== OUTPUT BEGIN ===
Checking PATCH 1/7: tcg: add headers for non-target helpers...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 80 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/7: Add plugin support...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#86:
new file mode 100644
ERROR: "(foo*)" should be "(foo *)"
#192: FILE: plugins/plugins.c:70:
+ g_module_symbol(g_module, "plugin_init", (gpointer*)&info->init);
ERROR: "(foo*)" should be "(foo *)"
#196: FILE: plugins/plugins.c:74:
+ (gpointer*)&info->needs_before_insn);
ERROR: "(foo*)" should be "(foo *)"
#198: FILE: plugins/plugins.c:76:
+ (gpointer*)&info->before_insn);
total: 3 errors, 1 warnings, 210 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/7: plugins: provide helper functions for plugins...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42:
new file mode 100644
total: 0 errors, 1 warnings, 49 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/7: tcg: add instrumenting module...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36:
new file mode 100644
total: 0 errors, 1 warnings, 84 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/7: plugins: add plugin template...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 38 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 6/7: plugin: add instruction execution logger...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13:
new file mode 100644
total: 0 errors, 1 warnings, 37 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/7: plugins: add syscall logging plugin sample...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644
ERROR: "(foo*)" should be "(foo *)"
#80: FILE: plugins/syscall-log/syscall-log.c:37:
+ qemulib_read_register(cpu, (uint8_t*)®, 0);
total: 1 errors, 1 warnings, 63 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
