On Jun 01 16:59, Peter Maydell wrote: > On 1 June 2018 at 16:34, Aaron Lindsay <[email protected]> wrote: > >> switch (extract32(id_isar0, 24, 4)) { > >> case 1: > >> set_feature(&features, ARM_FEATURE_THUMB_DIV); > >> break; > >> case 2: > >> set_feature(&features, ARM_FEATURE_ARM_DIV); > >> set_feature(&features, ARM_FEATURE_THUMB_DIV); > >> break; > >> default: > >> break; > >> } > > > > Should this switch/case be removed entirely? > > Yes, I think so (and also the id_isar0 variable and the > idregs[] entry which arranges to initialize it). We should > just set the THUMB_DIV and ARM_DIV features explicitly.
Okay, thanks for straightening me out! I sensed there was some inconsistency, but misjudged exactly where. I'll include this change in my next patchset. -Aaron -- Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
