On 05/18/2018 08:21 AM, Kevin Wolf wrote:
This adds a separate schema file for all job-related definitions that
aren't tied to the block layer.
For a start, move the enums JobType, JobStatus and JobVerb.
Signed-off-by: Kevin Wolf <[email protected]>
---
qapi/block-core.json | 90 +-----------------------------------------------
qapi/job.json | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++
qapi/qapi-schema.json | 1 +
Makefile | 9 +++++
Makefile.objs | 4 +++
5 files changed, 109 insertions(+), 89 deletions(-)
create mode 100644 qapi/job.json
Do you want to add a MAINTAINERS entry under a block section, so that
the block list is cc'd on changes to the new file, in addition to the
fact that it is already covered by normal QAPI reviewers? (If we do
that, block-core.json could also use such additional coverage.)
+++ b/Makefile
@@ -98,6 +98,7 @@ GENERATED_FILES += qapi/qapi-types-char.h
qapi/qapi-types-char.c
GENERATED_FILES += qapi/qapi-types-common.h qapi/qapi-types-common.c
GENERATED_FILES += qapi/qapi-types-crypto.h qapi/qapi-types-crypto.c
GENERATED_FILES += qapi/qapi-types-introspect.h qapi/qapi-types-introspect.c
+GENERATED_FILES += qapi/qapi-types-job.h qapi/qapi-types-job.c
GENERATED_FILES += qapi/qapi-types-migration.h qapi/qapi-types-migration.c
GENERATED_FILES += qapi/qapi-types-misc.h qapi/qapi-types-misc.c
GENERATED_FILES += qapi/qapi-types-net.h qapi/qapi-types-net.c
I've threatened to post a refactoring patch to make it so that adding a
new schema file doesn't require so many edits in the Makefile. Maybe I
should make good on that threat :)
But in the meantime, this looks good.
Reviewed-by: Eric Blake <[email protected]>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
