From: Petr Tesarik <[email protected]> The significand is passed to normalizeRoundAndPackFloat128() as high first, low second. The current code passes the integer first, so the result is incorrectly shifted left by 64 bits.
This bug affects the emulation of s390x instruction CXLGBR (convert from logical 64-bit binary-integer operand to extended BFP result). Cc: [email protected] Tested-by: Alex Bennée <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Petr Tesarik <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]> --- fpu/softfloat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index bc0f52fa54..d07419324a 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -3147,7 +3147,7 @@ float128 uint64_to_float128(uint64_t a, float_status *status) if (a == 0) { return float128_zero; } - return normalizeRoundAndPackFloat128(0, 0x406E, a, 0, status); + return normalizeRoundAndPackFloat128(0, 0x406E, 0, a, status); } -- 2.17.0
