On 01/27/2011 08:26 PM, Gerd Hoffmann wrote:
> Hi,
>
>> } else if (!strcmp(buf, "scsi")) {
>> type = IF_SCSI;
>> - max_devs = MAX_SCSI_DEVS;
>> + max_devs = 7;
>
>> That's very obviously not much more than a hack, but I don't think
>> blockdev.c can get the real number easily (please prove me wrong). With
>> this hack, we would get the old behaviour for -drive (which doesn't use
>> any other controller anyway) and you can still use -device to attach
>> more devices to a non-lsi bus.
>
> Looks sensible to me. scsi controllers with more than 7 devs (megasas
> and whatever else might be coming, virtio?) can't be added via if=scsi
> legacy syntax and must use -blockdev and -device anyway.
>
> We probably want add a comment explaining this though.
>
Yes please. It's a bit non-obvious that 'scsi' means in fact 'lsi'.
As long as there a way of specifying more than 8 devs
I'm fine with that patch.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
[email protected] +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
