"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> Signed-off-by: Juan Quintela <quint...@redhat.com>
>> Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
>
> Please print the magic with %x.
done.
>
>> + return -1;
>> + }
>> +
>> + if (msg.version != MULTIFD_VERSION) {
>> + error_setg(errp, "multifd: received packet version %d "
>> + "expected %d", msg.version, MULTIFD_VERSION);
>> + return -1;
>> + }
>> +
>> + if (memcmp(msg.uuid, &qemu_uuid, sizeof(qemu_uuid))) {
>> + char *uuid = qemu_uuid_unparse_strdup(&qemu_uuid);
>> + error_setg(errp, "multifd: received uuid '%s' and expected "
>> + "uuid '%s' for channel %hhd", msg.uuid, uuid, msg.id);
>
> I don't think you can just print msg.uuid there; it's the raw 16 bytes
> isn't it rather than a string?
You ae right.
> I suspect you need to do the unprase on both of them.
Done.
Thanks, Juan.
