On 04/22/2018 12:01 PM, Halil Pasic wrote:
On 04/22/2018 05:43 PM, Tony Krowiak wrote:
+ FEAT_INIT_MISC("ap", "AP facilities installed"),
Why plural ('facilities')? Would not s/facilities/instructions be
more end-user
friendly?
It's a matter of opinion. I prefer facilities because AP is comprised
of not only
instructions, but also AP processors.
Please elaborate. You mean processors like AP cards? If yes what if
the matrix is
empty (e.g. the state we decided is the default when no further action
is taken
(assign queues to the vfio-ap kernel driver, set up an mdev, -device
vfio-ap on
qemu cmd line))?
I just wanted to point out that this plural is very vague. Not
speaking about that
QCI should be an AP facility too, but is not included in this
'features' and is not
covered by this cpu model feature. It has it's own cpu model feature
and even a
dedicated STFLE bit.
FYI, I decided to take your suggestion and go with 'AP instructions
installed'.
Regards,
Halil
