On 04/25/18 21:08, Eric Blake wrote: > On 04/25/2018 02:05 PM, Laszlo Ersek wrote: > >>>>> + 'x86_64', 'xtensa', 'xtensaeb' ] } >>>> >>>> x86_64 doesn't match our typical conventions of preferring '-' over '_'; >>>> also, wikipedia mentions both spellings but under the page name >>>> 'x86-64'. Is it worth switching that enum constant? >>>> >>>> https://en.wikipedia.org/wiki/X86-64 >>> >>> I would not want that - SysEmuTarget is supposed to be correlated with >>> the qemu-system-$TARGET binary names and we use qemu-system-x86_64 >>> there. >> >> Right; also TARGET_NAME is looked up as follows in patch #4, in >> qmp_query_target(): >> >> + info->arch = qapi_enum_parse(&SysEmuTarget_lookup, TARGET_NAME, -1, >> + &error_abort); >> >> That would fail if we used "x86-64" here. > > Then worth a mention in the commit message to make it obvious that our > choice of _ for over-the-wire QMP is intentional. >
Right; I'll add a note to the schema too. Thanks! Laszlo
