On 04/25/2018 07:26 AM, Laszlo Ersek wrote:
> On 04/25/18 00:03, no-re...@patchew.org wrote:
>> Hi,
>>
>> This series failed docker-mingw@fedora build test. Please find the testing
>> commands and
>> their output below. If you have Docker installed, you can probably reproduce
>> it
>> locally.
>
> [snip]
>
>> qapi/qapi-types-misc.h:654:20: error: expected identifier or '(' before
>> numeric constant
>> CpuInfoX86 i386;
>> ^> Wow, is "i386" a macro on mingw, one that expands to a number? That is > incredibly st...range. > > I do need this enum constant to be "i386" in the QAPI schema, because > that's what TARGET_NAME will map to. > > Can I let the generator use the "q_" prefix here somehow? > > Alright, I'll add "i386" to "polluted_words" in "scripts/qapi/common.py". > > Sigh, what else is there already... I see Eric's commit 86ae191163d4 :( Yep, that's the right fix for working around header pollution. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
