On 04/20/2018 05:50 AM, Alex Bennée wrote: > +tcg_target_ulong __attribute__((flatten)) helper_le_ldq_mmu(CPUArchState > *env, > + target_ulong > addr, > + TCGMemOpIdx oi, > + uintptr_t > retaddr) > +{ > + return load_helper(env, addr, 8, false, false, oi, retaddr); > +}
This doesn't work for 32-bit host. You really do have to mind the block comment that you copied and use uint64_t, both in load_helper and as the return value here. > +#ifdef TARGET_WORDS_BIGENDIAN > +#define NEED_BE_BSWAP 0 > +#define NEED_LE_BSWAP 1 > +#else > +#define NEED_BE_BSWAP 1 > +#define NEED_LE_BSWAP 0 > +#endif Why have two variables for this? r~