On 12 April 2018 at 08:37, Eric Auger <[email protected]> wrote:
> Now we have relevant helpers for queue and irq
> management, let's implement MMIO write operations.
>
> Signed-off-by: Eric Auger <[email protected]>
> Signed-off-by: Prem Mallappa <[email protected]>
> -int smmuv3_cmdq_consume(SMMUv3State *s)
> +static int smmuv3_cmdq_consume(SMMUv3State *s)
> {
> SMMUCmdError cmd_error = SMMU_CERROR_NONE;
> SMMUQueue *q = &s->cmdq;
> @@ -269,11 +270,170 @@ int smmuv3_cmdq_consume(SMMUv3State *s)
> return 0;
> }
>
> -static MemTxResult smmu_write_mmio(void *opaque, hwaddr offset, uint64_t
> data,
You changed the name of the argument here from 'value' to 'data', which
is why the diff has come out looking a bit awkward like this.
Better to be consistent with the name from the start.
> +static MemTxResult smmu_writell(SMMUv3State *s, hwaddr offset,
> + uint64_t value, MemTxAttrs attrs)
Otherwise
Reviewed-by: Peter Maydell <[email protected]>
thanks
-- PMM
