On 04/09/2018 08:38 PM, Peter Maydell wrote: > +#if TARGET_LONG_BITS <= TCG_TARGET_REG_BITS > tcg_set_insn_param(s->insn_start, 2, syn); > +#else > + /* tcg_gen_insn_start has split every target_ulong argument to > + * op_insn_start into two 32-bit arguments, so we want the low > + * half of the 3rd argument, which is at index 4. > + */ > + tcg_set_insn_param(s->insn_start, 4, syn); > +#endif >
Ouch, good catch. I think we should fix this in tcg_set_insn_param instead, as several other targets are also affected by this. r~
