On 9 April 2018 at 10:39, Paolo Bonzini <[email protected]> wrote: > On 09/04/2018 07:58, Stefan Hajnoczi wrote: >> On Sun, Apr 08, 2018 at 11:59:33AM -0300, Philippe Mathieu-Daudé wrote: >>> memtohex() adds an extra trailing NUL character. >>> >>> Reported-by: AddressSanitizer >>> Signed-off-by: Philippe Mathieu-Daudé <[email protected]> >>> --- >>> (gdb) dump binary memory /tmp/dram.bin 0x94000000 0x94100000 >>> Remote connection closed >>> >>> ================================================================= >>> ==22732==ERROR: AddressSanitizer: stack-buffer-overflow on address >>> 0x7ffe43018340 at pc 0x55f2655fde81 bp 0x7ffe43017210 sp 0x7ffe43017208 >>> WRITE of size 1 at 0x7ffe43018340 thread T0 >>> >>> --- >>> gdbstub.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> Reviewed-by: Stefan Hajnoczi <[email protected]> > > Peter, can you apply this directly to master?
Applied, thanks. (patchwork and patches made a pig's ear of this for some reason, I think they got confused about where the commit message stopped and the patch started, so I had to hand-edit the files.) -- PMM
