The list did not author any patches, but it does rewrite the 'From:' header of messages sent from any domain with restrictive SPF policies that would otherwise prevent the message from reaching all list recipients. If a maintainer is not careful to undo the list header rewrite, and the author did not include a manual 'From:' line in the body to fix the munged header, then 'git am' happily attributes the patch to the list. Add some mailmap entries to correct the few that have escaped our attention; while we also work on improving the tooling to catch the problem in the future before a merge is even made.
Also improve the comments occurring in the file, including line length improvements. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Tested-by: Philippe Mathieu-Daudé <[email protected]> --- .mailmap | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/.mailmap b/.mailmap index cf689b9ec99..778a4d4e2c7 100644 --- a/.mailmap +++ b/.mailmap @@ -1,6 +1,7 @@ -# This mailmap just translates the weird addresses from the original import into git -# into proper addresses so that they are counted properly in git shortlog output. -# +# This mailmap fixes up author names/addresses. + +# The first section translates weird addresses from the original git import +# into proper addresses so that they are counted properly by git shortlog. Andrzej Zaborowski <[email protected]> balrog <balrog@c046a42c-6fe2-441c-8c8c-71466251a162> Anthony Liguori <[email protected]> aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162> Anthony Liguori <[email protected]> Anthony Liguori <[email protected]> @@ -15,10 +16,19 @@ Paul Burton <[email protected]> <[email protected]> Paul Burton <[email protected]> <[email protected]> Thiemo Seufer <[email protected]> ths <ths@c046a42c-6fe2-441c-8c8c-71466251a162> malc <[email protected]> malc <malc@c046a42c-6fe2-441c-8c8c-71466251a162> + # There is also a: # (no author) <(no author)@c046a42c-6fe2-441c-8c8c-71466251a162> # for the cvs2svn initialization commit e63c3dc74bf. -# + +# Next, translate a few commits where mailman rewrote the From: line due +# to strict SPF, although we prefer to avoid adding more entries like that. +Ed Swierk <[email protected]> Ed Swierk via Qemu-devel <[email protected]> +Ian McKellar <[email protected]> Ian McKellar via Qemu-devel <[email protected]> +Julia Suvorova <[email protected]> Julia Suvorova via Qemu-devel <[email protected]> +Justin Terry (VM) <[email protected]> Justin Terry (VM) via Qemu-devel <[email protected]> + + # Also list preferred name forms where people have changed their # git author config Daniel P. Berrangé <[email protected]> -- 2.14.3
