* Su Hang ([email protected]) wrote: > > Sincerely sorry for my negligence to cause this bug! > I will fix it as quick as I can! > > Sorry again, I'm really ashamed about the mistake I have made.
No need to be ashamed; bugs happen! Dave > Su Hang > > > -----Original Messages----- > > From: "Dr. David Alan Gilbert" <[email protected]> > > Sent Time: 2018-03-14 04:10:24 (Wednesday) > > To: "Vladimir Sementsov-Ogievskiy" <[email protected]>, > > [email protected], [email protected] > > Cc: "[email protected]" <[email protected]>, "Denis Lunev" > > <[email protected]>, "[email protected]" <[email protected]>, > > "[email protected]" <[email protected]>, "[email protected]" > > <[email protected]>, "[email protected]" <[email protected]>, > > "[email protected]" <[email protected]> > > Subject: Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration > > > > * Vladimir Sementsov-Ogievskiy ([email protected]) wrote: > > > It looks like a bug in a recent commit to checkpatch. It don't support do > > > { } while > > > > Yes, adding Su Hang and Eric in and trimming some others out. > > So yes, ignore this patchew failure for this case, but we need to fix > > that separately. > > > > Dave > > > > > > > > Best regards, > > > > > > Vladimir. > > > > > > ________________________________ > > > От: [email protected] <[email protected]> > > > Отправлено: 13 марта 2018 г. 22:03:29 > > > Кому: Vladimir Sementsov-Ogievskiy > > > Копия: [email protected]; [email protected]; [email protected]; > > > [email protected]; [email protected]; Vladimir Sementsov-Ogievskiy; > > > [email protected]; [email protected]; [email protected]; > > > [email protected]; [email protected]; [email protected]; > > > [email protected]; Denis Lunev; [email protected]; > > > [email protected]; [email protected] > > > Тема: Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration > > > > > > Hi, > > > > > > This series seems to have some coding style problems. See output below for > > > more information: > > > > > > Type: series > > > Message-id: [email protected] > > > Subject: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration > > > > > > === TEST SCRIPT BEGIN === > > > #!/bin/bash > > > > > > BASE=base > > > n=1 > > > total=$(git log --oneline $BASE.. | wc -l) > > > failed=0 > > > > > > git config --local diff.renamelimit 0 > > > git config --local diff.renames True > > > git config --local diff.algorithm histogram > > > > > > commits="$(git log --format=%H --reverse $BASE..)" > > > for c in $commits; do > > > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > > > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback > > > -; then > > > failed=1 > > > echo > > > fi > > > n=$((n+1)) > > > done > > > > > > exit $failed > > > === TEST SCRIPT END === > > > > > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > > > From https://github.com/patchew-project/qemu > > > * [new tag] > > > patchew/[email protected] -> > > > patchew/[email protected] > > > Auto packing the repository in background for optimum performance. > > > See "git help gc" for manual housekeeping. > > > Switched to a new branch 'test' > > > 71e03c4ecc iotests: add dirty bitmap postcopy test > > > daa548f79f iotests: add dirty bitmap migration test > > > 353c5fdae1 migration: add postcopy migration of dirty bitmaps > > > 1da07d4ba2 migration: allow qmp command migrate-start-postcopy for any > > > postcopy > > > b789a2887e migration: add is_active_iterate handler > > > 48eb14f856 migration/qemu-file: add qemu_put_counted_string() > > > 1d6549dae1 migration: include migrate_dirty_bitmaps in migrate_postcopy > > > e9e40af39a qapi: add dirty-bitmaps migration capability > > > c575185038 migration: introduce postcopy-only pending > > > 7cae35cd7c dirty-bitmap: add locked state > > > 47bbd2a70c block/dirty-bitmap: add _locked version of > > > bdrv_reclaim_dirty_bitmap > > > 870ff1d916 block/dirty-bitmap: fix locking in bdrv_reclaim_dirty_bitmap > > > 5dca3ae226 block/dirty-bitmap: add bdrv_dirty_bitmap_enable_successor() > > > > > > === OUTPUT BEGIN === > > > Checking PATCH 1/13: block/dirty-bitmap: add > > > bdrv_dirty_bitmap_enable_successor()... > > > Checking PATCH 2/13: block/dirty-bitmap: fix locking in > > > bdrv_reclaim_dirty_bitmap... > > > Checking PATCH 3/13: block/dirty-bitmap: add _locked version of > > > bdrv_reclaim_dirty_bitmap... > > > Checking PATCH 4/13: dirty-bitmap: add locked state... > > > Checking PATCH 5/13: migration: introduce postcopy-only pending... > > > Checking PATCH 6/13: qapi: add dirty-bitmaps migration capability... > > > Checking PATCH 7/13: migration: include migrate_dirty_bitmaps in > > > migrate_postcopy... > > > Checking PATCH 8/13: migration/qemu-file: add qemu_put_counted_string()... > > > Checking PATCH 9/13: migration: add is_active_iterate handler... > > > Checking PATCH 10/13: migration: allow qmp command migrate-start-postcopy > > > for any postcopy... > > > Checking PATCH 11/13: migration: add postcopy migration of dirty > > > bitmaps... > > > ERROR: braces {} are necessary for all arms of this statement > > > #737: FILE: migration/block-dirty-bitmap.c:690: > > > + } while (!(s.flags & DIRTY_BITMAP_MIG_FLAG_EOS)); > > > [...] > > > > > > total: 1 errors, 0 warnings, 816 lines checked > > > > > > Your patch has style problems, please review. If any of these errors > > > are false positives report them to the maintainer, see > > > CHECKPATCH in MAINTAINERS. > > > > > > Checking PATCH 12/13: iotests: add dirty bitmap migration test... > > > Checking PATCH 13/13: iotests: add dirty bitmap postcopy test... > > > === OUTPUT END === > > > > > > Test command exited with code: 1 > > > > > > > > > --- > > > Email generated automatically by Patchew [http://patchew.org/]. > > > Please send your feedback to [email protected] > > -- > > Dr. David Alan Gilbert / [email protected] / Manchester, UK -- Dr. David Alan Gilbert / [email protected] / Manchester, UK
