On Tue, Mar 13, 2018 at 02:49:42PM +0100, Paolo Bonzini wrote: > On 13/03/2018 14:40, Daniel P. Berrangé wrote: > >> @@ -52,9 +52,9 @@ env: > >> - CONFIG="" > >> - CONFIG="--enable-debug --enable-debug-tcg > >> --enable-trace-backends=log" > >> - CONFIG="--disable-linux-aio --disable-cap-ng --disable-attr > >> --disable-brlapi --disable-uuid --disable-libusb" > >> - - CONFIG="--enable-modules" > >> - - CONFIG="--with-coroutine=ucontext" > >> - - CONFIG="--with-coroutine=sigaltstack" > >> + - CONFIG="--enable-modules --disable-linux-user" > >> + - CONFIG="--with-coroutine=ucontext --disable-linux-user" > >> + - CONFIG="--with-coroutine=sigaltstack --disable-linux-user" > > Since this merged, the 4th, 5th & 6th jobs are now reliably completing in > > time, but the 1st and 3rd jobs are hitting timeouts on the majority of > > runs :-( > > > > We've already got a lot of jobs, but for sake of reliability should we > > consider splitting the 1st & 3rd jobs. Add --disable-linux-user to both > > of the existing jobs, and then adding 2 new jobs with --disable-system > > and --disable-tools set ? > > Out of curiosity, why do we need the third job at all? And > --enable-trace-backends=log is the default, so "--enable-debug > --enable-debug-tcg" should be enough.
Presumably that is intended to validate that code still builds correctly when various optional features are turned off, by exercising different codepaths in the countless #ifdef HAVE_$FEATURE conditionals we have. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
