On Tue, Mar 06, 2018 at 08:08:37PM +0000, Dr. David Alan Gilbert wrote:
> * Peter Xu ([email protected]) wrote:
> > When setting migration capabilities via QMP/HMP, we'll apply them even
> > if the capability check failed. Fix it.
> >
> > Fixes: 4a84214ebe ("migration: provide migrate_caps_check()", 2017-07-18)
> > Signed-off-by: Peter Xu <[email protected]>
>
> OK, yes, that works, so:
>
>
> Reviewed-by: Dr. David Alan Gilbert <[email protected]>
Thanks.
>
>
> It is a little odd in a way; 'caps_check' you might expect only checked
> and didn't change anything. migrate_params is organised a bit
> differently; and somewhat more confusingly.
Indeed. Maybe the cap_list copy should be within the function, and
then define the function as:
static bool migrate_caps_check(MigrationCapabilityStatusList *params,
Error **errp);
Then it at least looks more like the param_check one.
Let me know if you think it's good; I can post another one after
all, and this one would be easy. :)
--
Peter Xu
