Peter Maydell <[email protected]> writes: > On 27 February 2018 at 17:52, Alex Bennée <[email protected]> wrote: >> >> Richard Henderson <[email protected]> writes: >> >>> On 02/27/2018 06:38 AM, Alex Bennée wrote: >>>> @@ -11244,7 +11245,7 @@ static void disas_simd_indexed(DisasContext *s, >>>> uint32_t insn) >>>> } >>>> /* fall through */ >>>> case 0x9: /* FMUL, FMULX */ >>>> - if (!extract32(size, 1, 1)) { >>>> + if (size == 1) { >>>> unallocated_encoding(s); >>>> return; >>>> } >>> >>> This is still redundant, since size == 1 is handled... >> >> doh! >> >> will fix. > > I'd prefer it if you didn't, because I'm in the process of putting > this version of the patchset into target-arm.next...
Fair enough - you've picked up Richard's r-b? -- Alex Bennée
