On 23.02.2018 16:43, Collin L. Walling wrote: > Interactive boot menu for scsi. This follows a similar procedure > as the interactive menu for eckd dasd. An example follows: > > s390x Enumerated Boot Menu. > > 3 entries detected. Select from index 0 to 2. > > Signed-off-by: Collin L. Walling <[email protected]> > Reviewed-by: Thomas Huth <[email protected]> > --- > hw/s390x/ipl.c | 1 + > pc-bios/s390-ccw/bootmap.c | 4 ++++ > pc-bios/s390-ccw/main.c | 1 + > pc-bios/s390-ccw/menu.c | 20 ++++++++++++++++++++ > pc-bios/s390-ccw/s390-ccw.h | 2 ++ > 5 files changed, 28 insertions(+) > > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > index c12e460..edbec90 100644 > --- a/hw/s390x/ipl.c > +++ b/hw/s390x/ipl.c > @@ -246,6 +246,7 @@ static void s390_ipl_set_boot_menu(S390IPLState *ipl) > *flags |= QIPL_FLAG_BM_OPTS_ZIPL; > return; > } break still missing here ... > + case S390_IPL_TYPE_QEMU_SCSI: > break; > default: > error_report("boot menu is not supported for this device type.");
otherwise, LGTM -- Regards, Viktor Mihajlovski
