On Wed, Feb 21, 2018 at 10:19:05 -0800, Richard Henderson wrote:
> On 02/19/2018 06:26 PM, Emilio G. Cota wrote:
> > @@ -68,6 +69,7 @@ typedef struct DisasContextBase {
> > target_ulong pc_next;
> > DisasJumpType is_jmp;
> > unsigned int num_insns;
> > + int max_insns;
> > bool singlestep_enabled;
> > } DisasContextBase;
>
> We really should pick the same type for max_insns and num_insns, which ever
> type we settle on. I can't see how we can go wrong with unsigned...
I was just trying to avoid warnings with -Wsign-compare in case
we ever enabled it.
Should I bother converting the "bound" variables we use for
MIN(max_insns, bound) to unsigned as well? Or just leave them
alone and forget about -Wsign-compare?
Thanks,
Emilio
