On 02/07/2018 05:58 PM, Cornelia Huck wrote:
>
>> +##
>> +# @S390CrashReason:
>> +#
>> +# Reason why the CPU is in a crashed state.
>> +#
>> +# @unknown: no crash reason was set
>> +#
>> +# @disabledwait: the CPU has entered a disabled wait state
>> +#
>> +# @extintloop: timer interrupt with new PSW enabled for timer
>> +#
>> +# @pgmintloop: program interrupt with BAD new PSW
>> +#
>> +# @opintloop: operation exception interrupt with invalid code at the program
>> +# interrupt new PSW
>> +#
>> +# Since: 2.12
>> +##
>> +{ 'enum': 'S390CrashReason',
>> + 'data': [ 'unknown',
>> + 'disabledwait',
>> + 'extintloop',
>> + 'pgmintloop',
>> + 'opintloop' ] }
>
> Would some hyphens or underscores make this a bit more readable? FWICS,
> QAPI would create something like S390_CRASH_REASON_DISABLED_WAIT for
> 'disabled-wait', which looks reasonable to me.
disabled-wait
extint-loop
pgmint-loop
opint-loop
?
>
> With the build fix and the description change for extintloop, this
> looks fine to me (with or without a changed enum).
>
