On Fri, Feb 2, 2018 at 6:01 AM, <no-re...@patchew.org> wrote: > === OUTPUT BEGIN === > Checking PATCH 1/5: test-coroutine: add simple CoMutex test... > ERROR: do not initialise statics to 0 or NULL > #30: FILE: tests/test-coroutine.c:198: > +static bool locked = false; > > total: 1 errors, 0 warnings, 74 lines checked
I think we should fix this one too. Otherwise, Reviewed-by: Fam Zheng <f...@redhat.com> > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 2/5: lockable: add QemuLockable... > WARNING: line over 80 characters > #58: FILE: include/qemu/compiler.h:144: > +#define QEMU_GENERIC2(x, a0, ...) QEMU_GENERIC_IF(x, a0, QEMU_GENERIC1(x, > __VA_ARGS__)) > > WARNING: line over 80 characters > #59: FILE: include/qemu/compiler.h:145: > +#define QEMU_GENERIC3(x, a0, ...) QEMU_GENERIC_IF(x, a0, QEMU_GENERIC2(x, > __VA_ARGS__)) > > WARNING: line over 80 characters > #60: FILE: include/qemu/compiler.h:146: > +#define QEMU_GENERIC4(x, a0, ...) QEMU_GENERIC_IF(x, a0, QEMU_GENERIC3(x, > __VA_ARGS__)) > > WARNING: line over 80 characters > #61: FILE: include/qemu/compiler.h:147: > +#define QEMU_GENERIC5(x, a0, ...) QEMU_GENERIC_IF(x, a0, QEMU_GENERIC4(x, > __VA_ARGS__)) > > WARNING: line over 80 characters > #62: FILE: include/qemu/compiler.h:148: > +#define QEMU_GENERIC6(x, a0, ...) QEMU_GENERIC_IF(x, a0, QEMU_GENERIC5(x, > __VA_ARGS__)) > > WARNING: line over 80 characters > #63: FILE: include/qemu/compiler.h:149: > +#define QEMU_GENERIC7(x, a0, ...) QEMU_GENERIC_IF(x, a0, QEMU_GENERIC6(x, > __VA_ARGS__)) > > WARNING: line over 80 characters > #64: FILE: include/qemu/compiler.h:150: > +#define QEMU_GENERIC8(x, a0, ...) QEMU_GENERIC_IF(x, a0, QEMU_GENERIC7(x, > __VA_ARGS__)) > > WARNING: line over 80 characters > #65: FILE: include/qemu/compiler.h:151: > +#define QEMU_GENERIC9(x, a0, ...) QEMU_GENERIC_IF(x, a0, QEMU_GENERIC8(x, > __VA_ARGS__)) > > WARNING: line over 80 characters > #66: FILE: include/qemu/compiler.h:152: > +#define QEMU_GENERIC10(x, a0, ...) QEMU_GENERIC_IF(x, a0, QEMU_GENERIC9(x, > __VA_ARGS__)) > > WARNING: line over 80 characters > #124: FILE: include/qemu/lockable.h:28: > + * to QEMU_MAKE_LOCKABLE. For optimized builds, we can rely on dead-code > elimination > > WARNING: architecture specific defines should be avoided > #127: FILE: include/qemu/lockable.h:31: > +#ifdef __OPTIMIZE__ > > total: 0 errors, 11 warnings, 242 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > Checking PATCH 3/5: coroutine-lock: convert CoQueue to use QemuLockable... > Checking PATCH 4/5: coroutine-lock: make qemu_co_enter_next thread-safe... > Checking PATCH 5/5: curl: convert to CoQueue... > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-de...@freelists.org
