Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: [email protected] Subject: [Qemu-devel] [PATCH qemu] slirp/debug: Print IP addresses in human readable form === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 2d5b0a923e slirp/debug: Print IP addresses in human readable form === OUTPUT BEGIN === Checking PATCH 1/1: slirp/debug: Print IP addresses in human readable form... ERROR: code indent should never use tabs #43: FILE: slirp/socket.c:704: +^IDEBUG_ARG("haddr = %s", inet_ntoa(*(struct in_addr *)&haddr));$ ERROR: code indent should never use tabs #44: FILE: slirp/socket.c:705: +^IDEBUG_ARG("hport = %d", ntohs(hport));$ ERROR: code indent should never use tabs #45: FILE: slirp/socket.c:706: +^IDEBUG_ARG("laddr = %s", inet_ntoa(*(struct in_addr *)&laddr));$ ERROR: code indent should never use tabs #46: FILE: slirp/socket.c:707: +^IDEBUG_ARG("lport = %d", ntohs(lport));$ ERROR: code indent should never use tabs #60: FILE: slirp/udp.c:244: +^IDEBUG_ARG("saddr = %s", inet_ntoa(saddr->sin_addr));$ ERROR: code indent should never use tabs #61: FILE: slirp/udp.c:245: +^IDEBUG_ARG("daddr = %s", inet_ntoa(daddr->sin_addr));$ total: 6 errors, 0 warnings, 40 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
