On Wed, 31 Jan 2018 14:40:00 +0100 Christian Borntraeger <[email protected]> wrote:
> On 01/31/2018 01:51 PM, Peter Maydell wrote: > > On 31 January 2018 at 12:14, Christian Borntraeger > > <[email protected]> wrote: > >> On 01/30/2018 04:41 PM, Eric Blake wrote: > >>> On 01/30/2018 07:38 AM, Christian Borntraeger wrote: > >>>> +++ b/configure > >>>> @@ -1906,9 +1906,9 @@ int main(int argc, char *argv[]) { > >>>> EOF > >>>> > >>>> if compile_object ; then > >>>> - if grep -q BiGeNdIaN $TMPO ; then > >>>> + if strings -a $TMPO | grep -q BiGeNdIaN ; then > >>>> bigendian="yes" > >>>> - elif grep -q LiTtLeEnDiAn $TMPO ; then > >>>> + elif strings -a $TMPO | grep -q LiTtLeEnDiAn ; then > >>> > >>> Yes, this is indeed a more portable way to grep binary files (it's also > >>> possible to do: > >>> > >>> tr -d '\0' < $TMPO | grep -q ... > >>> > >>> if we're worried about the availability of strings, but I don't see that > >>> being a problem if no one reports it actually failing). > >>> > >>> Reviewed-by: Eric Blake <[email protected]> > >> > >> Peter, does that patch work on MacOS and Windows? If yes we could > >> get this patch in via the s390 tree. > > > > I haven't tested but I think it should be fine. OSX provides > > a strings binary that supports -a, and Windows cross-builds > > so it will use the Linux strings. > > > > thanks > > -- PMM > > > > Conny, can you take this patch via s390-next? > Sure, we'll notice anyway if something goes wrong after all. Thanks, queued to s390-next.
