Am 29.01.2018 um 17:57 hat Max Reitz geschrieben: > On 2018-01-11 20:52, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf <[email protected]> > > --- > > qapi/block-core.json | 33 ++++++++++++++++++++++++++++++++- > > 1 file changed, 32 insertions(+), 1 deletion(-) > > > > diff --git a/qapi/block-core.json b/qapi/block-core.json > > index 1749376c61..9341f6708d 100644 > > --- a/qapi/block-core.json > > +++ b/qapi/block-core.json > > @@ -3320,6 +3320,37 @@ > > { 'command': 'blockdev-del', 'data': { 'node-name': 'str' } } > > > > ## > > +# @BlockdevQcow2CompatLevel: > > +# @0_10: The original QCOW2 format as introduced in qemu 0.10 (version > > 2) > > +# @1_1: The extended QCOW2 format as introduced in qemu 1.1 (version 3) > > +# > > +# Since: 2.10 > > +## > > +{ 'enum': 'BlockdevQcow2CompatLevel', > > + 'data': [ '0_10', '1_1' ] } > > Just my two cents: I'd prefer 2 and 3 because I've never quite liked > that people are supposed to remember some pretty random qemu version > numbers anyway.
Yeah. An enum with '2' and '3' wouldn't work for Eric's desire to have enum values starting in letters, though. I was originally planning to replace it with an int, but then it's not introspectable. An enum with 'v2' and 'v3' then? Kevin
signature.asc
Description: PGP signature
