Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: [email protected] Subject: [Qemu-devel] [PATCH] linux-user: Use *at functions to implement interp_prefix === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/[email protected] -> patchew/[email protected] t [tag update] patchew/[email protected] -> patchew/[email protected] t [tag update] patchew/[email protected] -> patchew/[email protected] * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' df5366a6ba linux-user: Use *at functions to implement interp_prefix === OUTPUT BEGIN === Checking PATCH 1/1: linux-user: Use *at functions to implement interp_prefix... ERROR: do not use assignment in if condition #189: FILE: linux-user/syscall.c:8372: + if (!(fn = lock_user_string(arg2))) { ERROR: do not use assignment in if condition #207: FILE: linux-user/syscall.c:8393: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #222: FILE: linux-user/syscall.c:8405: + if (!(fn = lock_user_string(arg2))) { ERROR: do not use assignment in if condition #303: FILE: linux-user/syscall.c:9808: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #318: FILE: linux-user/syscall.c:9820: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #336: FILE: linux-user/syscall.c:10922: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #353: FILE: linux-user/syscall.c:10936: + if (!(fn = lock_user_string(arg1))) { ERROR: do not use assignment in if condition #371: FILE: linux-user/syscall.c:10962: + if (!(fn = lock_user_string(arg2))) { ERROR: do not use assignment in if condition #390: FILE: linux-user/syscall.c:11966: + if (!(fn = lock_user_string(arg2))) { total: 9 errors, 0 warnings, 349 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
