Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20180122034217.19593-1-richard.hender...@linaro.org Subject: [Qemu-devel] [PULL 00/43] Add hppa-softmmu === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20180119114444.7590-1-laur...@vivier.eu -> patchew/20180119114444.7590-1-laur...@vivier.eu * [new tag] patchew/20180122034217.19593-1-richard.hender...@linaro.org -> patchew/20180122034217.19593-1-richard.hender...@linaro.org Switched to a new branch 'test' 1687407469 hw/hppa: Add MAINTAINERS entry a144ceedc7 pc-bios: Add hppa-firmware.img and git submodule 262baa12eb hw/hppa: Implement DINO system board 861011fa36 target/hppa: Enable MTTCG a33c2a9ba7 target/hppa: Implement STWA a0bd1a1f9e target/hppa: Implement a pause instruction dd8a2f5d66 target/hppa: Implement LDSID for system mode bf83305a76 target/hppa: Fix comment 6573d13b70 target/hppa: Increase number of temp regs 233d10fe7b target/hppa: Use MMU_DEBUG_LOAD when reloading for CR[IIR] 1e7e106211 qom: Add MMU_DEBUG_LOAD 093de557ec target/hppa: Only use EXCP_DTLB_MISS abd6694b1f target/hppa: Implement B,GATE insn 488f6437c3 target/hppa: Add migration for the cpu 9175ea3f62 target/hppa: Add system registers to gdbstub 5035093e6c target/hppa: Optimize for flat addressing space a8b31280a6 target/hppa: Implement halt and reset instructions 2776293fe8 target/hppa: Implement SYNCDMA insn 024b754a8d target/hppa: Implement LCI f6ef83db5e target/hppa: Implement LPA 19a9042865 target/hppa: Implement LDWA 1b1df004c0 target/hppa: Implement P*TLB and P*TLBE insns 40465b87f2 target/hppa: Implement I*TLBA and I*TLBP insns e4f0feebe5 target/hppa: Log unimplemented instructions 98ca5d9fce target/hppa: Implement the interval timer 8d373824e0 target/hppa: Implement external interrupts cd7c359f3d target/hppa: Implement tlb_fill c9f5837fd0 target/hppa: Implement IASQ 29ee03eed4 target/hppa: Avoid privilege level decrease during branches dfa9805fdd target/hppa: Use space registers in data operations 501224b807 target/hppa: Implement unaligned access trap c4bc1abb49 target/hppa: Fill in hppa_cpu_do_interrupt/hppa_cpu_exec_interrupt 0986e0762b target/hppa: Implement rfi d0ca2d6e7c target/hppa: Adjust insn mask for mfctl, w 41b110fb97 target/hppa: Add control registers 071ae8ccbc target/hppa: Add space registers 7e834d986f target/hppa: Implement the system mask instructions 9520134730 target/hppa: Implement mmu_idx from IA privilege level b190bfe110 target/hppa: Split address size from register size c20827c03c target/hppa: Define hardware exception types 56fea7df22 target/hppa: Disable gateway page emulation for system mode 264997a4b6 target/hppa: Define the rest of the PSW d333744720 target/hppa: Skeleton support for hppa-softmmu === OUTPUT BEGIN === Checking PATCH 1/43: target/hppa: Skeleton support for hppa-softmmu... ERROR: do not use C99 // comments #73: FILE: hw/hppa/machine.c:35: + mc->default_ram_size = 2048UL*1024*1024; // 2GB ERROR: spaces required around that '*' (ctx:VxV) #73: FILE: hw/hppa/machine.c:35: + mc->default_ram_size = 2048UL*1024*1024; // 2GB ^ ERROR: spaces required around that '*' (ctx:VxV) #73: FILE: hw/hppa/machine.c:35: + mc->default_ram_size = 2048UL*1024*1024; // 2GB ^ total: 3 errors, 0 warnings, 185 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/43: target/hppa: Define the rest of the PSW... Checking PATCH 3/43: target/hppa: Disable gateway page emulation for system mode... Checking PATCH 4/43: target/hppa: Define hardware exception types... Checking PATCH 5/43: target/hppa: Split address size from register size... ERROR: space required after that ',' (ctx:VxV) #458: FILE: target/hppa/translate.c:155: +# define tcg_gen_trunc_reg_ptr(p,r) tcg_gen_trunc_i64_i32(TCGV_PTR_TO_NAT(p),r) ^ ERROR: space required after that ',' (ctx:VxV) #458: FILE: target/hppa/translate.c:155: +# define tcg_gen_trunc_reg_ptr(p,r) tcg_gen_trunc_i64_i32(TCGV_PTR_TO_NAT(p),r) ^ ERROR: space required after that ',' (ctx:VxV) #460: FILE: target/hppa/translate.c:157: +# define tcg_gen_trunc_reg_ptr(p,r) tcg_gen_mov_i64(TCGV_PTR_TO_NAT(p),r) ^ ERROR: space required after that ',' (ctx:VxV) #460: FILE: target/hppa/translate.c:157: +# define tcg_gen_trunc_reg_ptr(p,r) tcg_gen_mov_i64(TCGV_PTR_TO_NAT(p),r) ^ ERROR: space required after that ',' (ctx:VxV) #556: FILE: target/hppa/translate.c:253: +# define tcg_gen_trunc_reg_ptr(p,r) tcg_gen_mov_i32(TCGV_PTR_TO_NAT(p),r) ^ ERROR: space required after that ',' (ctx:VxV) #556: FILE: target/hppa/translate.c:253: +# define tcg_gen_trunc_reg_ptr(p,r) tcg_gen_mov_i32(TCGV_PTR_TO_NAT(p),r) ^ ERROR: space required after that ',' (ctx:VxV) #558: FILE: target/hppa/translate.c:255: +# define tcg_gen_trunc_reg_ptr(p,r) tcg_gen_extu_i32_i64(TCGV_PTR_TO_NAT(p),r) ^ ERROR: space required after that ',' (ctx:VxV) #558: FILE: target/hppa/translate.c:255: +# define tcg_gen_trunc_reg_ptr(p,r) tcg_gen_extu_i32_i64(TCGV_PTR_TO_NAT(p),r) ^ WARNING: line over 80 characters #913: FILE: target/hppa/translate.c:831: +static DisasCond do_cond(unsigned cf, TCGv_reg res, TCGv_reg cb_msb, TCGv_reg sv) ERROR: line over 90 characters #946: FILE: target/hppa/translate.c:882: +static DisasCond do_sub_cond(unsigned cf, TCGv_reg res, TCGv_reg in1, TCGv_reg in2, TCGv_reg sv) WARNING: line over 80 characters #973: FILE: target/hppa/translate.c:945: +static DisasCond do_unit_cond(unsigned cf, TCGv_reg res, TCGv_reg in1, TCGv_reg in2) WARNING: line over 80 characters #1045: FILE: target/hppa/translate.c:1021: +static TCGv_reg do_add_sv(DisasContext *ctx, TCGv_reg res, TCGv_reg in1, TCGv_reg in2) WARNING: line over 80 characters #1065: FILE: target/hppa/translate.c:1035: +static TCGv_reg do_sub_sv(DisasContext *ctx, TCGv_reg res, TCGv_reg in1, TCGv_reg in2) WARNING: line over 80 characters #1084: FILE: target/hppa/translate.c:1048: +static DisasJumpType do_add(DisasContext *ctx, unsigned rt, TCGv_reg in1, TCGv_reg in2, WARNING: line over 80 characters #1143: FILE: target/hppa/translate.c:1120: +static DisasJumpType do_sub(DisasContext *ctx, unsigned rt, TCGv_reg in1, TCGv_reg in2, WARNING: line over 80 characters #1226: FILE: target/hppa/translate.c:1215: +static DisasJumpType do_log(DisasContext *ctx, unsigned rt, TCGv_reg in1, TCGv_reg in2, WARNING: line over 80 characters #1227: FILE: target/hppa/translate.c:1216: + unsigned cf, void (*fn)(TCGv_reg, TCGv_reg, TCGv_reg)) total: 9 errors, 8 warnings, 2376 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 6/43: target/hppa: Implement mmu_idx from IA privilege level... Checking PATCH 7/43: target/hppa: Implement the system mask instructions... Checking PATCH 8/43: target/hppa: Add space registers... Checking PATCH 9/43: target/hppa: Add control registers... Checking PATCH 10/43: target/hppa: Adjust insn mask for mfctl, w... Checking PATCH 11/43: target/hppa: Implement rfi... Checking PATCH 12/43: target/hppa: Fill in hppa_cpu_do_interrupt/hppa_cpu_exec_interrupt... Checking PATCH 13/43: target/hppa: Implement unaligned access trap... Checking PATCH 14/43: target/hppa: Use space registers in data operations... Checking PATCH 15/43: target/hppa: Avoid privilege level decrease during branches... Checking PATCH 16/43: target/hppa: Implement IASQ... Checking PATCH 17/43: target/hppa: Implement tlb_fill... ERROR: spaces prohibited around that ':' (ctx:WxW) #25: FILE: target/hppa/cpu.h:172: + unsigned u : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #26: FILE: target/hppa/cpu.h:173: + unsigned t : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #27: FILE: target/hppa/cpu.h:174: + unsigned d : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #28: FILE: target/hppa/cpu.h:175: + unsigned b : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #29: FILE: target/hppa/cpu.h:176: + unsigned page_size : 4; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #30: FILE: target/hppa/cpu.h:177: + unsigned ar_type : 3; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #31: FILE: target/hppa/cpu.h:178: + unsigned ar_pl1 : 2; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #32: FILE: target/hppa/cpu.h:179: + unsigned ar_pl2 : 2; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #33: FILE: target/hppa/cpu.h:180: + unsigned entry_valid : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #34: FILE: target/hppa/cpu.h:181: + unsigned access_id : 16; ^ total: 10 errors, 0 warnings, 238 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 18/43: target/hppa: Implement external interrupts... Checking PATCH 19/43: target/hppa: Implement the interval timer... Checking PATCH 20/43: target/hppa: Log unimplemented instructions... Checking PATCH 21/43: target/hppa: Implement I*TLBA and I*TLBP insns... Checking PATCH 22/43: target/hppa: Implement P*TLB and P*TLBE insns... Checking PATCH 23/43: target/hppa: Implement LDWA... Checking PATCH 24/43: target/hppa: Implement LPA... Checking PATCH 25/43: target/hppa: Implement LCI... Checking PATCH 26/43: target/hppa: Implement SYNCDMA insn... Checking PATCH 27/43: target/hppa: Implement halt and reset instructions... Checking PATCH 28/43: target/hppa: Optimize for flat addressing space... Checking PATCH 29/43: target/hppa: Add system registers to gdbstub... Checking PATCH 30/43: target/hppa: Add migration for the cpu... ERROR: "(foo*)" should be "(foo *)" #202: FILE: target/hppa/machine.c:156: + VMSTATE_ARRAY(tlb, CPUHPPAState, ARRAY_SIZE(((CPUHPPAState*)0)->tlb), 0, total: 1 errors, 0 warnings, 198 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 31/43: target/hppa: Implement B,GATE insn... Checking PATCH 32/43: target/hppa: Only use EXCP_DTLB_MISS... Checking PATCH 33/43: qom: Add MMU_DEBUG_LOAD... Checking PATCH 34/43: target/hppa: Use MMU_DEBUG_LOAD when reloading for CR[IIR]... Checking PATCH 35/43: target/hppa: Increase number of temp regs... Checking PATCH 36/43: target/hppa: Fix comment... Checking PATCH 37/43: target/hppa: Implement LDSID for system mode... Checking PATCH 38/43: target/hppa: Implement a pause instruction... Checking PATCH 39/43: target/hppa: Implement STWA... Checking PATCH 40/43: target/hppa: Enable MTTCG... Checking PATCH 41/43: hw/hppa: Implement DINO system board... ERROR: spaces required around that '+' (ctx:VxV) #125: FILE: hw/hppa/dino.c:64: +#define DINO_LOCAL_IRQS (DINO_IRQS+1) ^ ERROR: spaces required around that '<<' (ctx:VxV) #127: FILE: hw/hppa/dino.c:66: +#define DINO_MASK_IRQ(x) (1<<(x)) ^ ERROR: do not use C99 // comments #141: FILE: hw/hppa/dino.c:80: +#define DINO_MEM_CHUNK_SIZE (8*1024*1024) // 8MB ERROR: spaces required around that '*' (ctx:VxV) #141: FILE: hw/hppa/dino.c:80: +#define DINO_MEM_CHUNK_SIZE (8*1024*1024) // 8MB ^ ERROR: spaces required around that '*' (ctx:VxV) #141: FILE: hw/hppa/dino.c:80: +#define DINO_MEM_CHUNK_SIZE (8*1024*1024) // 8MB ^ ERROR: spaces required around that '+' (ctx:VxV) #217: FILE: hw/hppa/dino.c:156: + case DINO_PCI_IO_DATA+2: ^ ERROR: spaces required around that '+' (ctx:VxV) #219: FILE: hw/hppa/dino.c:158: + case DINO_PCI_IO_DATA+1: ^ ERROR: spaces required around that '+' (ctx:VxV) #220: FILE: hw/hppa/dino.c:159: + case DINO_PCI_IO_DATA+3: ^ ERROR: spaces required around that '+' (ctx:VxV) #237: FILE: hw/hppa/dino.c:176: + case DINO_PCI_IO_DATA ... DINO_PCI_IO_DATA+3: ^ ERROR: spaces required around that '+' (ctx:VxV) #309: FILE: hw/hppa/dino.c:248: + case DINO_IO_DATA ... DINO_PCI_IO_DATA+3: ^ ERROR: code indent should never use tabs #589: FILE: hw/hppa/hppa_hardware.h:3: +#define FIRMWARE_START^I0xf0000000$ ERROR: code indent should never use tabs #590: FILE: hw/hppa/hppa_hardware.h:4: +#define FIRMWARE_END^I0xf0800000$ ERROR: code indent should never use tabs #592: FILE: hw/hppa/hppa_hardware.h:6: +#define DEVICE_HPA_LEN^I0x00100000$ ERROR: code indent should never use tabs #594: FILE: hw/hppa/hppa_hardware.h:8: +#define GSC_HPA^I^I0xffc00000$ ERROR: code indent should never use tabs #595: FILE: hw/hppa/hppa_hardware.h:9: +#define DINO_HPA^I0xfff80000$ ERROR: code indent should never use tabs #596: FILE: hw/hppa/hppa_hardware.h:10: +#define DINO_UART_HPA^I0xfff83000$ ERROR: code indent should never use tabs #597: FILE: hw/hppa/hppa_hardware.h:11: +#define DINO_UART_BASE^I0xfff83800$ ERROR: code indent should never use tabs #598: FILE: hw/hppa/hppa_hardware.h:12: +#define DINO_SCSI_HPA^I0xfff8c000$ ERROR: code indent should never use tabs #599: FILE: hw/hppa/hppa_hardware.h:13: +#define LASI_HPA^I0xffd00000$ ERROR: code indent should never use tabs #600: FILE: hw/hppa/hppa_hardware.h:14: +#define LASI_UART_HPA^I0xffd05000$ ERROR: code indent should never use tabs #601: FILE: hw/hppa/hppa_hardware.h:15: +#define LASI_SCSI_HPA^I0xffd06000$ ERROR: code indent should never use tabs #602: FILE: hw/hppa/hppa_hardware.h:16: +#define LASI_LAN_HPA^I0xffd07000$ ERROR: code indent should never use tabs #603: FILE: hw/hppa/hppa_hardware.h:17: +#define LASI_LPT_HPA^I0xffd02000$ ERROR: code indent should never use tabs #604: FILE: hw/hppa/hppa_hardware.h:18: +#define LASI_AUDIO_HPA^I0xffd04000$ ERROR: code indent should never use tabs #605: FILE: hw/hppa/hppa_hardware.h:19: +#define LASI_PS2KBD_HPA^I0xffd08000$ ERROR: code indent should never use tabs #606: FILE: hw/hppa/hppa_hardware.h:20: +#define LASI_PS2MOU_HPA^I0xffd08100$ ERROR: code indent should never use tabs #607: FILE: hw/hppa/hppa_hardware.h:21: +#define LASI_GFX_HPA^I0xf8000000$ ERROR: code indent should never use tabs #608: FILE: hw/hppa/hppa_hardware.h:22: +#define CPU_HPA^I^I0xfff10000$ ERROR: code indent should never use tabs #609: FILE: hw/hppa/hppa_hardware.h:23: +#define MEMORY_HPA^I0xfffbf000$ ERROR: if this code is redundant consider removing it #629: FILE: hw/hppa/hppa_hardware.h:43: +#if 0 WARNING: line over 80 characters #630: FILE: hw/hppa/hppa_hardware.h:44: +[ 2.160168] 1. Phantom PseudoBC GSC+ Port at 0xffc00000 [8] { 7, 0x0, 0x504, 0x00000 } ERROR: space prohibited before open square bracket '[' #630: FILE: hw/hppa/hppa_hardware.h:44: +[ 2.160168] 1. Phantom PseudoBC GSC+ Port at 0xffc00000 [8] { 7, 0x0, 0x504, 0x00000 } ERROR: spaces required around that '+' (ctx:VxW) #630: FILE: hw/hppa/hppa_hardware.h:44: +[ 2.160168] 1. Phantom PseudoBC GSC+ Port at 0xffc00000 [8] { 7, 0x0, 0x504, 0x00000 } ^ ERROR: space prohibited after that open square bracket '[' #630: FILE: hw/hppa/hppa_hardware.h:44: +[ 2.160168] 1. Phantom PseudoBC GSC+ Port at 0xffc00000 [8] { 7, 0x0, 0x504, 0x00000 } WARNING: line over 80 characters #631: FILE: hw/hppa/hppa_hardware.h:45: +[ 2.260162] 2. Dino PCI Bridge at 0xfff80000 [8/0] { 13, 0x3, 0x680, 0x0000a } ERROR: space prohibited before open square bracket '[' #631: FILE: hw/hppa/hppa_hardware.h:45: +[ 2.260162] 2. Dino PCI Bridge at 0xfff80000 [8/0] { 13, 0x3, 0x680, 0x0000a } ERROR: spaces required around that '/' (ctx:VxV) #631: FILE: hw/hppa/hppa_hardware.h:45: +[ 2.260162] 2. Dino PCI Bridge at 0xfff80000 [8/0] { 13, 0x3, 0x680, 0x0000a } ^ ERROR: space prohibited after that open square bracket '[' #631: FILE: hw/hppa/hppa_hardware.h:45: +[ 2.260162] 2. Dino PCI Bridge at 0xfff80000 [8/0] { 13, 0x3, 0x680, 0x0000a } ERROR: line over 90 characters #632: FILE: hw/hppa/hppa_hardware.h:46: +[ 2.350158] 3. Merlin+ 132 Dino RS-232 at 0xfff83000 [8/0/63] { 10, 0x0, 0x022, 0x0008c } ERROR: space prohibited before open square bracket '[' #632: FILE: hw/hppa/hppa_hardware.h:46: +[ 2.350158] 3. Merlin+ 132 Dino RS-232 at 0xfff83000 [8/0/63] { 10, 0x0, 0x022, 0x0008c } ERROR: spaces required around that '+' (ctx:VxW) #632: FILE: hw/hppa/hppa_hardware.h:46: +[ 2.350158] 3. Merlin+ 132 Dino RS-232 at 0xfff83000 [8/0/63] { 10, 0x0, 0x022, 0x0008c } ^ ERROR: spaces required around that '-' (ctx:VxV) #632: FILE: hw/hppa/hppa_hardware.h:46: +[ 2.350158] 3. Merlin+ 132 Dino RS-232 at 0xfff83000 [8/0/63] { 10, 0x0, 0x022, 0x0008c } ^ ERROR: spaces required around that '/' (ctx:VxV) #632: FILE: hw/hppa/hppa_hardware.h:46: +[ 2.350158] 3. Merlin+ 132 Dino RS-232 at 0xfff83000 [8/0/63] { 10, 0x0, 0x022, 0x0008c } ^ ERROR: spaces required around that '/' (ctx:VxV) #632: FILE: hw/hppa/hppa_hardware.h:46: +[ 2.350158] 3. Merlin+ 132 Dino RS-232 at 0xfff83000 [8/0/63] { 10, 0x0, 0x022, 0x0008c } ^ ERROR: space prohibited after that open square bracket '[' #632: FILE: hw/hppa/hppa_hardware.h:46: +[ 2.350158] 3. Merlin+ 132 Dino RS-232 at 0xfff83000 [8/0/63] { 10, 0x0, 0x022, 0x0008c } WARNING: line over 80 characters #633: FILE: hw/hppa/hppa_hardware.h:47: +[ 2.450160] 4. Merlin 160 Core FW-SCSI at 0xfff8c000 [8/12] { 4, 0x0, 0x03d, 0x00089 } ERROR: space prohibited before open square bracket '[' #633: FILE: hw/hppa/hppa_hardware.h:47: +[ 2.450160] 4. Merlin 160 Core FW-SCSI at 0xfff8c000 [8/12] { 4, 0x0, 0x03d, 0x00089 } ERROR: spaces required around that '-' (ctx:VxV) #633: FILE: hw/hppa/hppa_hardware.h:47: +[ 2.450160] 4. Merlin 160 Core FW-SCSI at 0xfff8c000 [8/12] { 4, 0x0, 0x03d, 0x00089 } ^ ERROR: spaces required around that '/' (ctx:VxV) #633: FILE: hw/hppa/hppa_hardware.h:47: +[ 2.450160] 4. Merlin 160 Core FW-SCSI at 0xfff8c000 [8/12] { 4, 0x0, 0x03d, 0x00089 } ^ ERROR: space prohibited after that open square bracket '[' #633: FILE: hw/hppa/hppa_hardware.h:47: +[ 2.450160] 4. Merlin 160 Core FW-SCSI at 0xfff8c000 [8/12] { 4, 0x0, 0x03d, 0x00089 } ERROR: line over 90 characters #634: FILE: hw/hppa/hppa_hardware.h:48: +[ 2.550161] 5. Merlin 160 Core BA at 0xffd00000 [8/16] { 11, 0x0, 0x03d, 0x00081 }, additional addresses: 0xffd0c000 0xffc00000 ERROR: space prohibited before open square bracket '[' #634: FILE: hw/hppa/hppa_hardware.h:48: +[ 2.550161] 5. Merlin 160 Core BA at 0xffd00000 [8/16] { 11, 0x0, 0x03d, 0x00081 }, additional addresses: 0xffd0c000 0xffc00000 ERROR: spaces required around that '/' (ctx:VxV) #634: FILE: hw/hppa/hppa_hardware.h:48: +[ 2.550161] 5. Merlin 160 Core BA at 0xffd00000 [8/16] { 11, 0x0, 0x03d, 0x00081 }, additional addresses: 0xffd0c000 0xffc00000 ^ ERROR: spaces required around that ':' (ctx:VxW) #634: FILE: hw/hppa/hppa_hardware.h:48: +[ 2.550161] 5. Merlin 160 Core BA at 0xffd00000 [8/16] { 11, 0x0, 0x03d, 0x00081 }, additional addresses: 0xffd0c000 0xffc00000 ^ ERROR: space prohibited after that open square bracket '[' #634: FILE: hw/hppa/hppa_hardware.h:48: +[ 2.550161] 5. Merlin 160 Core BA at 0xffd00000 [8/16] { 11, 0x0, 0x03d, 0x00081 }, additional addresses: 0xffd0c000 0xffc00000 ERROR: line over 90 characters #635: FILE: hw/hppa/hppa_hardware.h:49: +[ 2.700165] 6. Merlin 160 Core RS-232 at 0xffd05000 [8/16/4] { 10, 0x0, 0x03d, 0x0008c } ERROR: space prohibited before open square bracket '[' #635: FILE: hw/hppa/hppa_hardware.h:49: +[ 2.700165] 6. Merlin 160 Core RS-232 at 0xffd05000 [8/16/4] { 10, 0x0, 0x03d, 0x0008c } ERROR: spaces required around that '-' (ctx:VxV) #635: FILE: hw/hppa/hppa_hardware.h:49: +[ 2.700165] 6. Merlin 160 Core RS-232 at 0xffd05000 [8/16/4] { 10, 0x0, 0x03d, 0x0008c } ^ ERROR: spaces required around that '/' (ctx:VxV) #635: FILE: hw/hppa/hppa_hardware.h:49: +[ 2.700165] 6. Merlin 160 Core RS-232 at 0xffd05000 [8/16/4] { 10, 0x0, 0x03d, 0x0008c } ^ ERROR: spaces required around that '/' (ctx:VxV) #635: FILE: hw/hppa/hppa_hardware.h:49: +[ 2.700165] 6. Merlin 160 Core RS-232 at 0xffd05000 [8/16/4] { 10, 0x0, 0x03d, 0x0008c } ^ ERROR: space prohibited after that open square bracket '[' #635: FILE: hw/hppa/hppa_hardware.h:49: +[ 2.700165] 6. Merlin 160 Core RS-232 at 0xffd05000 [8/16/4] { 10, 0x0, 0x03d, 0x0008c } WARNING: line over 80 characters #636: FILE: hw/hppa/hppa_hardware.h:50: +[ 2.800160] 7. Merlin 160 Core SCSI at 0xffd06000 [8/16/5] { 10, 0x0, 0x03d, 0x00082 } ERROR: space prohibited before open square bracket '[' #636: FILE: hw/hppa/hppa_hardware.h:50: +[ 2.800160] 7. Merlin 160 Core SCSI at 0xffd06000 [8/16/5] { 10, 0x0, 0x03d, 0x00082 } ERROR: spaces required around that '/' (ctx:VxV) #636: FILE: hw/hppa/hppa_hardware.h:50: +[ 2.800160] 7. Merlin 160 Core SCSI at 0xffd06000 [8/16/5] { 10, 0x0, 0x03d, 0x00082 } ^ ERROR: spaces required around that '/' (ctx:VxV) #636: FILE: hw/hppa/hppa_hardware.h:50: +[ 2.800160] 7. Merlin 160 Core SCSI at 0xffd06000 [8/16/5] { 10, 0x0, 0x03d, 0x00082 } ^ ERROR: space prohibited after that open square bracket '[' #636: FILE: hw/hppa/hppa_hardware.h:50: +[ 2.800160] 7. Merlin 160 Core SCSI at 0xffd06000 [8/16/5] { 10, 0x0, 0x03d, 0x00082 } ERROR: line over 90 characters #637: FILE: hw/hppa/hppa_hardware.h:51: +[ 2.900162] 8. Merlin 160 Core LAN (802.3) at 0xffd07000 [8/16/6] { 10, 0x0, 0x03d, 0x0008a } ERROR: space prohibited before open square bracket '[' #637: FILE: hw/hppa/hppa_hardware.h:51: +[ 2.900162] 8. Merlin 160 Core LAN (802.3) at 0xffd07000 [8/16/6] { 10, 0x0, 0x03d, 0x0008a } ERROR: space prohibited between function name and open parenthesis '(' #637: FILE: hw/hppa/hppa_hardware.h:51: +[ 2.900162] 8. Merlin 160 Core LAN (802.3) at 0xffd07000 [8/16/6] { 10, 0x0, 0x03d, 0x0008a } ERROR: spaces required around that '/' (ctx:VxV) #637: FILE: hw/hppa/hppa_hardware.h:51: +[ 2.900162] 8. Merlin 160 Core LAN (802.3) at 0xffd07000 [8/16/6] { 10, 0x0, 0x03d, 0x0008a } ^ ERROR: spaces required around that '/' (ctx:VxV) #637: FILE: hw/hppa/hppa_hardware.h:51: +[ 2.900162] 8. Merlin 160 Core LAN (802.3) at 0xffd07000 [8/16/6] { 10, 0x0, 0x03d, 0x0008a } ^ ERROR: space prohibited after that open square bracket '[' #637: FILE: hw/hppa/hppa_hardware.h:51: +[ 2.900162] 8. Merlin 160 Core LAN (802.3) at 0xffd07000 [8/16/6] { 10, 0x0, 0x03d, 0x0008a } ERROR: line over 90 characters #638: FILE: hw/hppa/hppa_hardware.h:52: +[ 3.010187] 9. Merlin 160 Core Centronics at 0xffd02000 [8/16/0] { 10, 0x0, 0x03d, 0x00074 }, additional addresses: 0xffd01000 0xffd03000 ERROR: space prohibited before open square bracket '[' #638: FILE: hw/hppa/hppa_hardware.h:52: +[ 3.010187] 9. Merlin 160 Core Centronics at 0xffd02000 [8/16/0] { 10, 0x0, 0x03d, 0x00074 }, additional addresses: 0xffd01000 0xffd03000 ERROR: spaces required around that '/' (ctx:VxV) #638: FILE: hw/hppa/hppa_hardware.h:52: +[ 3.010187] 9. Merlin 160 Core Centronics at 0xffd02000 [8/16/0] { 10, 0x0, 0x03d, 0x00074 }, additional addresses: 0xffd01000 0xffd03000 ^ ERROR: spaces required around that '/' (ctx:VxV) #638: FILE: hw/hppa/hppa_hardware.h:52: +[ 3.010187] 9. Merlin 160 Core Centronics at 0xffd02000 [8/16/0] { 10, 0x0, 0x03d, 0x00074 }, additional addresses: 0xffd01000 0xffd03000 ^ ERROR: spaces required around that ':' (ctx:VxW) #638: FILE: hw/hppa/hppa_hardware.h:52: +[ 3.010187] 9. Merlin 160 Core Centronics at 0xffd02000 [8/16/0] { 10, 0x0, 0x03d, 0x00074 }, additional addresses: 0xffd01000 0xffd03000 ^ ERROR: space prohibited after that open square bracket '[' #638: FILE: hw/hppa/hppa_hardware.h:52: +[ 3.010187] 9. Merlin 160 Core Centronics at 0xffd02000 [8/16/0] { 10, 0x0, 0x03d, 0x00074 }, additional addresses: 0xffd01000 0xffd03000 ERROR: line over 90 characters #639: FILE: hw/hppa/hppa_hardware.h:53: +[ 3.170204] 10. Merlin 160 Core Audio at 0xffd04000 [8/16/1] { 10, 0x4, 0x03d, 0x0007b } ERROR: space prohibited before open square bracket '[' #639: FILE: hw/hppa/hppa_hardware.h:53: +[ 3.170204] 10. Merlin 160 Core Audio at 0xffd04000 [8/16/1] { 10, 0x4, 0x03d, 0x0007b } ERROR: spaces required around that '/' (ctx:VxV) #639: FILE: hw/hppa/hppa_hardware.h:53: +[ 3.170204] 10. Merlin 160 Core Audio at 0xffd04000 [8/16/1] { 10, 0x4, 0x03d, 0x0007b } ^ ERROR: spaces required around that '/' (ctx:VxV) #639: FILE: hw/hppa/hppa_hardware.h:53: +[ 3.170204] 10. Merlin 160 Core Audio at 0xffd04000 [8/16/1] { 10, 0x4, 0x03d, 0x0007b } ^ ERROR: space prohibited after that open square bracket '[' #639: FILE: hw/hppa/hppa_hardware.h:53: +[ 3.170204] 10. Merlin 160 Core Audio at 0xffd04000 [8/16/1] { 10, 0x4, 0x03d, 0x0007b } ERROR: line over 90 characters #640: FILE: hw/hppa/hppa_hardware.h:54: +[ 3.270157] 11. Merlin 160 Core PS/2 Port at 0xffd08000 [8/16/7] { 10, 0x0, 0x03d, 0x00084 } ERROR: space prohibited before open square bracket '[' #640: FILE: hw/hppa/hppa_hardware.h:54: +[ 3.270157] 11. Merlin 160 Core PS/2 Port at 0xffd08000 [8/16/7] { 10, 0x0, 0x03d, 0x00084 } ERROR: spaces required around that '/' (ctx:VxV) #640: FILE: hw/hppa/hppa_hardware.h:54: +[ 3.270157] 11. Merlin 160 Core PS/2 Port at 0xffd08000 [8/16/7] { 10, 0x0, 0x03d, 0x00084 } ^ ERROR: spaces required around that '/' (ctx:VxV) #640: FILE: hw/hppa/hppa_hardware.h:54: +[ 3.270157] 11. Merlin 160 Core PS/2 Port at 0xffd08000 [8/16/7] { 10, 0x0, 0x03d, 0x00084 } ^ ERROR: spaces required around that '/' (ctx:VxV) #640: FILE: hw/hppa/hppa_hardware.h:54: +[ 3.270157] 11. Merlin 160 Core PS/2 Port at 0xffd08000 [8/16/7] { 10, 0x0, 0x03d, 0x00084 } ^ ERROR: space prohibited after that open square bracket '[' #640: FILE: hw/hppa/hppa_hardware.h:54: +[ 3.270157] 11. Merlin 160 Core PS/2 Port at 0xffd08000 [8/16/7] { 10, 0x0, 0x03d, 0x00084 } ERROR: line over 90 characters #641: FILE: hw/hppa/hppa_hardware.h:55: +[ 3.370151] 12. Merlin 160 Core PS/2 Port at 0xffd08100 [8/16/8] { 10, 0x0, 0x03d, 0x00084 } ERROR: space prohibited before open square bracket '[' #641: FILE: hw/hppa/hppa_hardware.h:55: +[ 3.370151] 12. Merlin 160 Core PS/2 Port at 0xffd08100 [8/16/8] { 10, 0x0, 0x03d, 0x00084 } ERROR: spaces required around that '/' (ctx:VxV) #641: FILE: hw/hppa/hppa_hardware.h:55: +[ 3.370151] 12. Merlin 160 Core PS/2 Port at 0xffd08100 [8/16/8] { 10, 0x0, 0x03d, 0x00084 } ^ ERROR: spaces required around that '/' (ctx:VxV) #641: FILE: hw/hppa/hppa_hardware.h:55: +[ 3.370151] 12. Merlin 160 Core PS/2 Port at 0xffd08100 [8/16/8] { 10, 0x0, 0x03d, 0x00084 } ^ ERROR: spaces required around that '/' (ctx:VxV) #641: FILE: hw/hppa/hppa_hardware.h:55: +[ 3.370151] 12. Merlin 160 Core PS/2 Port at 0xffd08100 [8/16/8] { 10, 0x0, 0x03d, 0x00084 } ^ ERROR: space prohibited after that open square bracket '[' #641: FILE: hw/hppa/hppa_hardware.h:55: +[ 3.370151] 12. Merlin 160 Core PS/2 Port at 0xffd08100 [8/16/8] { 10, 0x0, 0x03d, 0x00084 } WARNING: line over 80 characters #642: FILE: hw/hppa/hppa_hardware.h:56: +[ 3.480148] 13. Coral SGC Graphics at 0xfa000000 [8/4] { 10, 0x0, 0x004, 0x00077 } ERROR: space prohibited before open square bracket '[' #642: FILE: hw/hppa/hppa_hardware.h:56: +[ 3.480148] 13. Coral SGC Graphics at 0xfa000000 [8/4] { 10, 0x0, 0x004, 0x00077 } ERROR: spaces required around that '/' (ctx:VxV) #642: FILE: hw/hppa/hppa_hardware.h:56: +[ 3.480148] 13. Coral SGC Graphics at 0xfa000000 [8/4] { 10, 0x0, 0x004, 0x00077 } ^ ERROR: space prohibited after that open square bracket '[' #642: FILE: hw/hppa/hppa_hardware.h:56: +[ 3.480148] 13. Coral SGC Graphics at 0xfa000000 [8/4] { 10, 0x0, 0x004, 0x00077 } WARNING: line over 80 characters #643: FILE: hw/hppa/hppa_hardware.h:57: +[ 3.570145] 14. Coral SGC Graphics at 0xf4000000 [8/8] { 10, 0x0, 0x004, 0x00077 } ERROR: space prohibited before open square bracket '[' #643: FILE: hw/hppa/hppa_hardware.h:57: +[ 3.570145] 14. Coral SGC Graphics at 0xf4000000 [8/8] { 10, 0x0, 0x004, 0x00077 } ERROR: spaces required around that '/' (ctx:VxV) #643: FILE: hw/hppa/hppa_hardware.h:57: +[ 3.570145] 14. Coral SGC Graphics at 0xf4000000 [8/8] { 10, 0x0, 0x004, 0x00077 } ^ ERROR: space prohibited after that open square bracket '[' #643: FILE: hw/hppa/hppa_hardware.h:57: +[ 3.570145] 14. Coral SGC Graphics at 0xf4000000 [8/8] { 10, 0x0, 0x004, 0x00077 } ERROR: line over 90 characters #644: FILE: hw/hppa/hppa_hardware.h:58: +[ 3.670146] 15. Gecko GSC Core Graphics at 0xf8000000 [8/24] { 10, 0x0, 0x016, 0x00085 }, additional addresses: 0xf0011000 ERROR: space prohibited before open square bracket '[' #644: FILE: hw/hppa/hppa_hardware.h:58: +[ 3.670146] 15. Gecko GSC Core Graphics at 0xf8000000 [8/24] { 10, 0x0, 0x016, 0x00085 }, additional addresses: 0xf0011000 ERROR: spaces required around that '/' (ctx:VxV) #644: FILE: hw/hppa/hppa_hardware.h:58: +[ 3.670146] 15. Gecko GSC Core Graphics at 0xf8000000 [8/24] { 10, 0x0, 0x016, 0x00085 }, additional addresses: 0xf0011000 ^ ERROR: spaces required around that ':' (ctx:VxW) #644: FILE: hw/hppa/hppa_hardware.h:58: +[ 3.670146] 15. Gecko GSC Core Graphics at 0xf8000000 [8/24] { 10, 0x0, 0x016, 0x00085 }, additional addresses: 0xf0011000 ^ ERROR: space prohibited after that open square bracket '[' #644: FILE: hw/hppa/hppa_hardware.h:58: +[ 3.670146] 15. Gecko GSC Core Graphics at 0xf8000000 [8/24] { 10, 0x0, 0x016, 0x00085 }, additional addresses: 0xf0011000 ERROR: line over 90 characters #645: FILE: hw/hppa/hppa_hardware.h:59: +[ 3.810147] 16. Merlin L2 160 (9000/778/B160L) at 0xfffbe000 [62] { 0, 0x0, 0x502, 0x00004 } ERROR: space prohibited before open square bracket '[' #645: FILE: hw/hppa/hppa_hardware.h:59: +[ 3.810147] 16. Merlin L2 160 (9000/778/B160L) at 0xfffbe000 [62] { 0, 0x0, 0x502, 0x00004 } ERROR: spaces required around that '/' (ctx:VxV) #645: FILE: hw/hppa/hppa_hardware.h:59: +[ 3.810147] 16. Merlin L2 160 (9000/778/B160L) at 0xfffbe000 [62] { 0, 0x0, 0x502, 0x00004 } ^ ERROR: spaces required around that '/' (ctx:VxV) #645: FILE: hw/hppa/hppa_hardware.h:59: +[ 3.810147] 16. Merlin L2 160 (9000/778/B160L) at 0xfffbe000 [62] { 0, 0x0, 0x502, 0x00004 } ^ ERROR: space prohibited after that open square bracket '[' #645: FILE: hw/hppa/hppa_hardware.h:59: +[ 3.810147] 16. Merlin L2 160 (9000/778/B160L) at 0xfffbe000 [62] { 0, 0x0, 0x502, 0x00004 } ERROR: space prohibited before open square bracket '[' #646: FILE: hw/hppa/hppa_hardware.h:60: +[ 3.920139] 17. Memory at 0xfffbf000 [63] { 1, 0x0, 0x067, 0x00009 } ERROR: space prohibited after that open square bracket '[' #646: FILE: hw/hppa/hppa_hardware.h:60: +[ 3.920139] 17. Memory at 0xfffbf000 [63] { 1, 0x0, 0x067, 0x00009 } ERROR: line over 90 characters #647: FILE: hw/hppa/hppa_hardware.h:61: +[ 4.000142] 18. Merlin+ 132 Dino PS/2 Port at 0xfff81000 [1] { 10, 0x0, 0x022, 0x00096 } ERROR: space prohibited before open square bracket '[' #647: FILE: hw/hppa/hppa_hardware.h:61: +[ 4.000142] 18. Merlin+ 132 Dino PS/2 Port at 0xfff81000 [1] { 10, 0x0, 0x022, 0x00096 } ERROR: spaces required around that '+' (ctx:VxW) #647: FILE: hw/hppa/hppa_hardware.h:61: +[ 4.000142] 18. Merlin+ 132 Dino PS/2 Port at 0xfff81000 [1] { 10, 0x0, 0x022, 0x00096 } ^ ERROR: spaces required around that '/' (ctx:VxV) #647: FILE: hw/hppa/hppa_hardware.h:61: +[ 4.000142] 18. Merlin+ 132 Dino PS/2 Port at 0xfff81000 [1] { 10, 0x0, 0x022, 0x00096 } ^ ERROR: space prohibited after that open square bracket '[' #647: FILE: hw/hppa/hppa_hardware.h:61: +[ 4.000142] 18. Merlin+ 132 Dino PS/2 Port at 0xfff81000 [1] { 10, 0x0, 0x022, 0x00096 } ERROR: space prohibited between function name and open parenthesis '(' #648: FILE: hw/hppa/hppa_hardware.h:62: +[ 4.231309] CPU(s): 1 out of 1 PA7300LC (PCX-L2) at 160.000000 MHz online ERROR: spaces required around that ':' (ctx:VxW) #648: FILE: hw/hppa/hppa_hardware.h:62: +[ 4.231309] CPU(s): 1 out of 1 PA7300LC (PCX-L2) at 160.000000 MHz online ^ ERROR: spaces required around that '-' (ctx:VxV) #648: FILE: hw/hppa/hppa_hardware.h:62: +[ 4.231309] CPU(s): 1 out of 1 PA7300LC (PCX-L2) at 160.000000 MHz online ^ ERROR: space prohibited after that open square bracket '[' #648: FILE: hw/hppa/hppa_hardware.h:62: +[ 4.231309] CPU(s): 1 out of 1 PA7300LC (PCX-L2) at 160.000000 MHz online ERROR: spaces required around that '/' (ctx:VxV) #650: FILE: hw/hppa/hppa_hardware.h:64: +./hppa-softmmu/qemu-system-hppa -kernel bios.bin -nographic -serial mon:stdio ^ ERROR: spaces required around that '-' (ctx:VxV) #650: FILE: hw/hppa/hppa_hardware.h:64: +./hppa-softmmu/qemu-system-hppa -kernel bios.bin -nographic -serial mon:stdio ^ ERROR: spaces required around that '/' (ctx:VxV) #650: FILE: hw/hppa/hppa_hardware.h:64: +./hppa-softmmu/qemu-system-hppa -kernel bios.bin -nographic -serial mon:stdio ^ ERROR: spaces required around that '-' (ctx:VxV) #650: FILE: hw/hppa/hppa_hardware.h:64: +./hppa-softmmu/qemu-system-hppa -kernel bios.bin -nographic -serial mon:stdio ^ ERROR: spaces required around that '-' (ctx:VxV) #650: FILE: hw/hppa/hppa_hardware.h:64: +./hppa-softmmu/qemu-system-hppa -kernel bios.bin -nographic -serial mon:stdio ^ ERROR: spaces required around that '-' (ctx:WxV) #650: FILE: hw/hppa/hppa_hardware.h:64: +./hppa-softmmu/qemu-system-hppa -kernel bios.bin -nographic -serial mon:stdio ^ ERROR: spaces required around that '-' (ctx:WxV) #650: FILE: hw/hppa/hppa_hardware.h:64: +./hppa-softmmu/qemu-system-hppa -kernel bios.bin -nographic -serial mon:stdio ^ ERROR: spaces required around that '-' (ctx:WxV) #650: FILE: hw/hppa/hppa_hardware.h:64: +./hppa-softmmu/qemu-system-hppa -kernel bios.bin -nographic -serial mon:stdio ^ ERROR: spaces required around that ':' (ctx:VxV) #650: FILE: hw/hppa/hppa_hardware.h:64: +./hppa-softmmu/qemu-system-hppa -kernel bios.bin -nographic -serial mon:stdio ^ ERROR: space required after that ',' (ctx:VxV) #760: FILE: hw/hppa/machine.c:83: + cpu[i], g_strdup_printf("cpu%ld-io-eir",i), 4); ^ ERROR: spaces required around that '*' (ctx:VxV) #761: FILE: hw/hppa/machine.c:84: + memory_region_add_subregion(addr_space, CPU_HPA + i*0x1000, cpu_region); ^ ERROR: spaces required around that '*' (ctx:VxV) #929: FILE: hw/hppa/machine.c:252: + cpu[i]->env.gr[5] = CPU_HPA + i*0x1000; ^ total: 130 errors, 6 warnings, 995 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 42/43: pc-bios: Add hppa-firmware.img and git submodule... Checking PATCH 43/43: hw/hppa: Add MAINTAINERS entry... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org