Re: [Qemu-devel] [RFC 1/2] memory: do explicit cleanup when remove listeners

[Paolo Bonzini]

On 19/01/2018 09:42, Peter Xu wrote:
> +    FOR_EACH_FLAT_RANGE(fr, view) {

listener->begin is missing before the loop.

Paolo

> +        MemoryRegionSection section = section_from_flat_range(fr, view);
> +
> +        if (fr->dirty_log_mask && listener->log_stop) {
> +            listener->log_stop(listener, &section, fr->dirty_log_mask, 0);
> +        }
> +        if (listener->region_del) {
> +            listener->region_del(listener, &section);
> +        }
> +    }
> +    if (listener->commit) {
> +        listener->commit(listener);
> +    }
> +    flatview_unref(view);