On 15.01.2018 13:00, BALATON Zoltan wrote: > On Mon, 15 Jan 2018, Thomas Huth wrote: >> ppc64-softmmu is a superset of ppc-softmmu which in turn is a superset >> of ppcemb-softmmu. But since the config files are currently independent >> from each other, we missed to define some CONFIG switches in the super- >> sets: CONFIG_SUNGEM is missing from the ppc64-softmmu config, and the >> CONFIG_IDE_SII3112 switch is only defined in ppcemb-softmmu. > > I'm not sure about this. The Sun GEM network interface is a device > typically found on Apple PowerMacs but also seems to be found on G5 > based Macs so it's probably OK to add. The SiI3112 is now only used on > the (not yet fully merged) Sam460EX emulation which is to be added to > ppcemb, that's why I've only added it to that target.
But as I wrote: ppc-softmmu is currently a superset of ppcemb-softmmu. I think people expect to be able to run the same amount of machines with ppc-softmmu than with ppcemb-softmmu, don't they? >> (off-topic question: Do we still need a separate ppcemb-softmmu nowadays? >> It seemed to be useful 10 years ago when everybody was doing KVM on >> embedded PPC, but these days seem to be pretty much over now, so IMHO >> just using ppc-softmmu for embedded should be enough nowadays? We could >> save quite some compilation- and "make check"-time if we could finally >> get rid of ppcemb-softmmu again...) > > I've also noticed that most of the boards were available both in ppcemb > and ppc targets so maybe these could be merged now to avoid confusion > but I don't know the reason why ppcemb existed in the first place so I > don't know what other implications dropping ppcemb may have. An alternative would be to remove the embedded configs from the ppc-softmmu.mak and only include them in ppcemb-softmmu.mak, so that there is a stricter distinction. I think the current situation is rather confusing, where it is possible that the user could try to run a pseries machine with an embedded PPC CPU for example ... so strictly separating the embedded stuff into ppcemb-softmmu would maybe really make sense. Thomas
