On 4 January 2011 15:15, Aurelien Jarno <[email protected]> wrote:
> Use bits32 instead of uint32 when manipulating floating point values
> directly for consistency reasons.
I'm not convinced this patch is particularly worthwhile, especially since
Andreas is working on a patchset which will convert all the bits32
uses back into uint32_t anyway, which is the direction to go if we
want to make the fpu/ code consistent about its type usage.
If you do want to do this, the commit message should be "uint32_t"
not "uint32" (which is a different type!)
> int float32_is_quiet_nan( float32 a1 )
> {
> float32u u;
> - uint64_t a;
> + bits32 a;
> u.f = a1;
> a = u.i;
> return ( 0xFF800000 < ( a<<1 ) );
This change is actually changing the type: shouldn't it be bits64 ?
It seems a bit inconsistent to change softfloat-native.c:float32_is_quiet_nan()
but not softfloat-native.c:float64_is_quiet_nan() (which uses uint64_t).
Personally I'd just drop this patch.
-- PMM
