On 12/18/2017 06:44 PM, Richard Henderson wrote:
> On 12/11/2017 04:56 AM, Alex Bennée wrote:
>> +static inline float16 float16_set_sign(float16 a, int sign)
>> +{
>> + return make_float16((float16_val(a) & 0x7fff) | (sign << 15));
>> +}
>> +
>
> 1) Do we use this anywhere?
>
> 2) While this is probably in line with the other implementations,
> but going to a more qemu-ish style this should use deposit32.Yes, it is easier to read while reviewing (no mask or shift), so safer. That's probably why I'm becoming addict of the "hw/registerfields.h" API... :)
signature.asc
Description: OpenPGP digital signature
