On Wed, Jan 03, 2018 at 08:10:58AM +0100, Paolo Bonzini wrote: > On 28/12/2017 08:29, Peter Xu wrote: > > There were existing work that tried to allow chardev to be run in a > > dedicated gcontext rather than the default main context/thread. > > Basically that work passed in the correct gcontext during > > g_source_attach(). However, I found something missing along the way, > > that some legacy glib APIs are used by chardev code which take the > > main context as default: > > > > g_timeout_add_seconds > > g_timeout_add > > g_idle_add > > > > To fully allow the chardevs to be run in dedicated gcontext, we need > > to convert all these legacy APIs into g_source_attach() calls as well, > > with the correct gcontext passed in. > > > > This series tries to clean the rest of things up. > > > > I picked up patch 1 from monitor-oob series into this series (which is > > a missing of chardev frontend call fix for g_source_attach()), so that > > this series can be a complete fix. > > > > Please review. Thanks, > > > > Peter Xu (3): > > chardev: use backend chr context when watch for fe > > chardev: let g_idle_add() be with chardev gcontext > > chardev: introduce qemu_chr_timeout_add() and use > > > > chardev/char-fe.c | 2 +- > > chardev/char-pty.c | 16 ++++++++-------- > > chardev/char-socket.c | 4 ++-- > > chardev/char.c | 20 ++++++++++++++++++++ > > hw/char/terminal3270.c | 7 ++++--- > > include/chardev/char.h | 2 ++ > > 6 files changed, 37 insertions(+), 14 deletions(-) > > > > All queued, thanks!
Paolo, Would you like to queue V2 of the series which fixed the issue that Marc-Andre has pointed out (Note that there is a v2.1 for patch 3). Thanks anyways! -- Peter Xu
