On Mon, 4 Dec 2017 12:17:06 +0100
Christian Borntraeger <borntrae...@de.ibm.com> wrote:
> On 11/28/2017 02:46 PM, Cornelia Huck wrote:
> > The autogenerated nics should be treated as any other device; use
> > qdev_set_id() to have them show up under peripheral-anon.
> >
> I think this is fine, but then I ask myself how x86 does this. So I tried to
> find out how the pc-q35 machine does this but I somehow failed to understand
> how they do it. Do you have any clue?
It seems they don't. If you start up a machine with only autogenerated
devices, you won't find anything under peripheral{-anon}, but several
devices under unattached.
So, maybe we should change this for everything? Or just leave it alone?
(The css-bridge change is a different thing IMO, it clearly should be
attached to the machine.)
>
> > Signed-off-by: Cornelia Huck <coh...@redhat.com>
> > ---
> > hw/s390x/s390-virtio-ccw.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> > index a23b8aec9f..830bae9d0f 100644
> > --- a/hw/s390x/s390-virtio-ccw.c
> > +++ b/hw/s390x/s390-virtio-ccw.c
> > @@ -35,6 +35,7 @@
> > #include "cpu_models.h"
> > #include "qapi/qmp/qerror.h"
> > #include "hw/nmi.h"
> > +#include "include/monitor/qdev.h"
> >
> > S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)
> > {
> > @@ -259,6 +260,7 @@ static void s390_create_virtio_net(BusState *bus, const
> > char *name)
> >
> > dev = qdev_create(bus, name);
> > qdev_set_nic_properties(dev, nd);
> > + qdev_set_id(dev, NULL);
> > qdev_init_nofail(dev);
> > }
> > }
> >
>
