Hi, This series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [PATCH v6 00/26] tcg: generic vector operations Type: series Message-id: [email protected] === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 25cb597f1f tcg/aarch64: Add vector operations 3f5327e6d4 tcg/i386: Add vector operations/expansions for mul/extend 9842ec4914 target/arm: Use vector infrastructure for aa64 widening shifts 5baa8f3688 tcg: Add generic vector ops for extension f31da52954 target/arm: Use vector infrastructure for aa64 multiplies 32e58411b7 tcg: Add generic vector ops for multiplication 02b126c0de tcg/i386: Add vector operations/expansions for shift/cmp/interleave bd28e62249 target/arm: Use vector infrastructure for aa64 compares c1bffde42b tcg: Add generic vector ops for comparisons c6dfe9f8f3 target/arm: Use vector infrastructure for aa64 constant shifts 692cd8553b tcg: Add generic vector ops for constant shifts 77a9e02822 target/arm: Use vector infrastructure for aa64 zip/uzp/trn/xtn 8b8ba000ae tcg: Add generic vector ops for interleave e5c9bc047b tcg: Add tcg_expand_vec_op and tcg-target.opc.h 8f2687485e tcg/i386: Add vector operations 2895593422 target/arm: Use vector infrastructure for aa64 dup/movi 75b6cdbaa6 target/arm: Use vector infrastructure for aa64 mov/not/neg 01af1be046 target/arm: Use vector infrastructure for aa64 add/sub/logic f368c49794 target/arm: Align vector registers 0870bb2a3c tcg: Add tcg_signed_cond 0ac77ecb27 tcg: Allow multiple word entries into the constant pool 729ef7471e tcg: Add generic vector expanders b0b5925754 tcg: Add types and basic operations for host vectors cfb22624a4 tcg: Generalize TCGOp parameters 17d3aaf14a tcg: Dynamically allocate TCGOps 795ee71296 tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED* === OUTPUT BEGIN === Checking PATCH 1/26: tcg: Remove TCGV_UNUSED* and TCGV_IS_UNUSED*... Checking PATCH 2/26: tcg: Dynamically allocate TCGOps... ERROR: line over 90 characters #64: FILE: include/qemu/queue.h:430: + (var) && ((prev_var) = (*(((struct headname *)((var)->field.tqe_prev))->tqh_last)), 1); \ ERROR: spaces prohibited around that ':' (ctx:WxW) #538: FILE: tcg/tcg.h:575: + unsigned life : 16; /* 32 */ ^ total: 2 errors, 0 warnings, 520 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/26: tcg: Generalize TCGOp parameters... ERROR: spaces prohibited around that ':' (ctx:WxW) #110: FILE: tcg/tcg.h:570: + unsigned param1 : 4; /* 12 */ ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #111: FILE: tcg/tcg.h:571: + unsigned param2 : 4; /* 16 */ ^ ERROR: Macros with complex values should be enclosed in parenthesis #119: FILE: tcg/tcg.h:583: +#define TCGOP_CALLI(X) (X)->param1 ERROR: Macros with complex values should be enclosed in parenthesis #120: FILE: tcg/tcg.h:584: +#define TCGOP_CALLO(X) (X)->param2 total: 4 errors, 0 warnings, 92 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/26: tcg: Add types and basic operations for host vectors... ERROR: externs should be avoided in .c files #137: FILE: tcg/tcg-op-vec.c:37: +extern TCGv_i32 TCGV_LOW_link_error(TCGv_i64); ERROR: externs should be avoided in .c files #138: FILE: tcg/tcg-op-vec.c:38: +extern TCGv_i32 TCGV_HIGH_link_error(TCGv_i64); ERROR: Macros with complex values should be enclosed in parenthesis #535: FILE: tcg/tcg-opc.h:209: +#define IMPLVEC TCG_OPF_VECTOR | IMPL(TCG_TARGET_MAYBE_vec) WARNING: line over 80 characters #538: FILE: tcg/tcg-opc.h:212: +DEF(movi_vec, 1, 0, 0, TCG_OPF_VECTOR | TCG_OPF_NOT_PRESENT) /* vecl defines const args */ ERROR: Macros with complex values should be enclosed in parenthesis #800: FILE: tcg/tcg.h:615: +#define TCGOP_VECL(X) (X)->param1 ERROR: Macros with complex values should be enclosed in parenthesis #801: FILE: tcg/tcg.h:616: +#define TCGOP_VECE(X) (X)->param2 total: 5 errors, 1 warnings, 807 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/26: tcg: Add generic vector expanders... ERROR: spaces required around that '&' (ctx:WxO) #320: FILE: accel/tcg/tcg-runtime-gvec.c:281: + *(vec64 *)(d + i) = *(vec64 *)(a + i) &~ *(vec64 *)(b + i); ^ ERROR: space prohibited after that '~' (ctx:OxW) #320: FILE: accel/tcg/tcg-runtime-gvec.c:281: + *(vec64 *)(d + i) = *(vec64 *)(a + i) &~ *(vec64 *)(b + i); ^ ERROR: spaces required around that '|' (ctx:WxO) #331: FILE: accel/tcg/tcg-runtime-gvec.c:292: + *(vec64 *)(d + i) = *(vec64 *)(a + i) |~ *(vec64 *)(b + i); ^ ERROR: space prohibited after that '~' (ctx:OxW) #331: FILE: accel/tcg/tcg-runtime-gvec.c:292: + *(vec64 *)(d + i) = *(vec64 *)(a + i) |~ *(vec64 *)(b + i); ^ total: 4 errors, 0 warnings, 1642 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 6/26: tcg: Allow multiple word entries into the constant pool... ERROR: spaces prohibited around that ':' (ctx:WxW) #23: FILE: tcg/tcg-pool.inc.c:26: + int addend : 32; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #24: FILE: tcg/tcg-pool.inc.c:27: + int rtype : 16; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #25: FILE: tcg/tcg-pool.inc.c:28: + int nlong : 16; ^ total: 3 errors, 0 warnings, 156 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 7/26: tcg: Add tcg_signed_cond... Checking PATCH 8/26: target/arm: Align vector registers... Checking PATCH 9/26: target/arm: Use vector infrastructure for aa64 add/sub/logic... Checking PATCH 10/26: target/arm: Use vector infrastructure for aa64 mov/not/neg... Checking PATCH 11/26: target/arm: Use vector infrastructure for aa64 dup/movi... Checking PATCH 12/26: tcg/i386: Add vector operations... Checking PATCH 13/26: tcg: Add tcg_expand_vec_op and tcg-target.opc.h... Checking PATCH 14/26: tcg: Add generic vector ops for interleave... ERROR: code indent should never use tabs #41: FILE: accel/tcg/tcg-runtime-gvec.c:318: +^I*(TYPE *)(d + 2 * i + 0) = *(TYPE *)(a + i); \$ ERROR: code indent should never use tabs #42: FILE: accel/tcg/tcg-runtime-gvec.c:319: +^I*(TYPE *)(d + 2 * i + sizeof(TYPE)) = *(TYPE *)(b + i); \$ ERROR: code indent should never use tabs #87: FILE: accel/tcg/tcg-runtime-gvec.c:364: +^I*(TYPE *)(d + i + 0) = ae; \$ ERROR: code indent should never use tabs #88: FILE: accel/tcg/tcg-runtime-gvec.c:365: +^I*(TYPE *)(d + i + sizeof(TYPE)) = be; \$ total: 4 errors, 0 warnings, 684 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 15/26: target/arm: Use vector infrastructure for aa64 zip/uzp/trn/xtn... Checking PATCH 16/26: tcg: Add generic vector ops for constant shifts... Checking PATCH 17/26: target/arm: Use vector infrastructure for aa64 constant shifts... Checking PATCH 18/26: tcg: Add generic vector ops for comparisons... ERROR: spaces required around that '*' (ctx:WxV) #24: FILE: accel/tcg/tcg-runtime-gvec.c:530: + *(TYPE *)(d + i) = *(TYPE *)(a + i) OP *(TYPE *)(b + i); \ ^ ERROR: spaces required around that '==' (ctx:WxB) #30: FILE: accel/tcg/tcg-runtime-gvec.c:536: + DO_CMP1(gvec_eq##SZ, vec##SZ, ==) \ ^ ERROR: spaces required around that '!=' (ctx:WxB) #31: FILE: accel/tcg/tcg-runtime-gvec.c:537: + DO_CMP1(gvec_ne##SZ, vec##SZ, !=) \ ^ ERROR: spaces required around that '<' (ctx:WxB) #32: FILE: accel/tcg/tcg-runtime-gvec.c:538: + DO_CMP1(gvec_lt##SZ, svec##SZ, <) \ ^ ERROR: spaces required around that '<=' (ctx:WxB) #33: FILE: accel/tcg/tcg-runtime-gvec.c:539: + DO_CMP1(gvec_le##SZ, svec##SZ, <=) \ ^ ERROR: spaces required around that '<' (ctx:WxB) #34: FILE: accel/tcg/tcg-runtime-gvec.c:540: + DO_CMP1(gvec_ltu##SZ, vec##SZ, <) \ ^ ERROR: spaces required around that '<=' (ctx:WxB) #35: FILE: accel/tcg/tcg-runtime-gvec.c:541: + DO_CMP1(gvec_leu##SZ, vec##SZ, <=) ^ ERROR: space prohibited after that '&&' (ctx:ExW) #247: FILE: tcg/tcg-op-gvec.c:1775: + && (TCG_TARGET_REG_BITS == 32 || vece != MO_64) ^ total: 8 errors, 0 warnings, 356 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 19/26: target/arm: Use vector infrastructure for aa64 compares... Checking PATCH 20/26: tcg/i386: Add vector operations/expansions for shift/cmp/interleave... Checking PATCH 21/26: tcg: Add generic vector ops for multiplication... Checking PATCH 22/26: target/arm: Use vector infrastructure for aa64 multiplies... Checking PATCH 23/26: tcg: Add generic vector ops for extension... Checking PATCH 24/26: target/arm: Use vector infrastructure for aa64 widening shifts... Checking PATCH 25/26: tcg/i386: Add vector operations/expansions for mul/extend... Checking PATCH 26/26: tcg/aarch64: Add vector operations... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to [email protected]
